feat: set Creation, LastAccess and LastWrite time for files by vbreuss · Pull Request #875 · TestableIO/System.IO.Abstractions

vbreuss · 2022-08-10T20:39:15Z

Implements #872
Adjust CreationTime, LastAccessTime and LastWriteTime when interacting with files in the MockFileSystem.

Provides a means to mock the used DateTime by calling e.g.

varfixedTime=newDateTime(2022,01,01);varfileSystem=newMockFileSystem().MockTime(()=>fixedTime);// All times will now be set to the fixedTime.

Implementes the following logic in MockFile:
All these cases are covered by unit tests in MockFileAdjustTimesTest

When creating files
CreationTime, LastAccessTime and LastWriteTime are set to the current time
When changing files (WriteAllText, WriteAllBytes, AppendAllText, OpenWrite, Open)
LastAccessTime and LastWriteTime are set to the current time
CreationTime is left unchanged
When reading files (ReadAllText, ReadAllLines, ReadAllBytes, OpenRead)
LastAccessTime is set to the current time
CreationTime and LastWriteTime are left unchanged
When setting attributes or ACLs (SetAttributes, SetAccessControl)
LastAccessTime is set to the current time
CreationTime and LastWriteTime are left unchanged
When moving files (Move)
LastAccessTime is set to the current time
CreationTime and LastWriteTime are left unchanged
When copying files (Copy)
CreationTime and LastAccessTime of the copied file in the destination directory is set to the current time
LastWriteTime and all times of the source file are left unchanged

vbreuss · 2022-08-11T18:59:28Z

Please note, that I changed the Interface IMockFileDataAccessor.
This interface looks like it is intended for internal use, but as it is public this could be considered a breaking change...

I am not sure what I should do:
I could increase the version or use default interface methods from C# 8

vbreuss · 2022-08-17T05:38:53Z

If this is an accepted approach, I could also try to have a look at #839, which deals with the times of directories. This would probably be quite similar...

fgreinacher · 2022-08-17T05:47:08Z

Sorry @vbreuss, I'm a bit busy with other things, will try to have a look by the end of this week!

fgreinacher

@vbreuss Looks very good so far, I made some suggestions.

I'm leaving for summer vacation soon, feel free to finish the review with @siprbaum and ping me for merge!

Also apply time in MockFileStream Mark MockFile_AfterSetAccessControl_ShouldUpdateLastAccessTime as Windows-Only Fix name of unit tests to match the actual expected behavior

…ind` in the various methods/properties.

…ess-and-last-write-times

vbreuss · 2022-08-31T07:22:19Z

@siprbaum : I merged the latest changes, so that this branch is up to date.
All comments are either fixed and resolved, or I left a comment explaining, why I implemented it this way. Could you please have a look again at this pull request?

… of a real file system

vbreuss · 2022-09-02T12:01:48Z

@siprbaum : Thanks for the review!
I implemented the changes and answered your findings.
Can you please have a look again, and resolve the comments, that you agree with?

Regarding the user detectable behaviour change:
As we are now setting the times correctly, the behaviour changes when previously in the tests you would (incorrectly) rely upon unchanged times for the files.
However I am still unsure, if I should increment the version when considering my previous comment in this pull request, regarding the change in the interface IMockFileDataAccessor.
What do you think?

…ess-and-last-write-times

vbreuss · 2022-09-10T13:52:49Z

@fgreinacher : I merged the latest main branch and answered or fixed all review comments.
Can you please have a look?

Co-authored-by: Florian Greinacher <florian@greinacher.de>

…t-write-times

github-actions · 2022-11-18T20:03:59Z

This is addressed in release v17.2.3.

github-actions · 2022-11-28T18:46:44Z

This is addressed in release v17.2.3.

vbreuss changed the title ~~feat: Set Creation, LastAccess and LastWrite time for files~~feat: #872 Set Creation, LastAccess and LastWrite time for filesAug 10, 2022

vbreuss force-pushed the feature/872-set-creation-last-access-and-last-write-times branch 3 times, most recently from 7ecbd63 to 30df259Compare August 11, 2022 18:52

vbreuss changed the title ~~feat: #872 Set Creation, LastAccess and LastWrite time for files~~feat: Set Creation, LastAccess and LastWrite time for filesAug 16, 2022

siprbaum reviewed Aug 17, 2022
View reviewed changes

fgreinacher reviewed Aug 20, 2022
View reviewed changes

Comment threadsrc/System.IO.Abstractions.TestingHelpers/MockFileSystem.cs Outdated
Comment threadsrc/System.IO.Abstractions.TestingHelpers/MockFileSystem.cs
Comment threadsrc/System.IO.Abstractions.TestingHelpers/MockFileSystem.cs Outdated

vbtigand others added 3 commits August 26, 2022 12:14

Adjust times in MockFileSystem
e60ff0b
Also apply time in MockFileStream Mark MockFile_AfterSetAccessControl_ShouldUpdateLastAccessTime as Windows-Only Fix name of unit tests to match the actual expected behavior

Avoid null for dateTimeProvider when deserializing
1b567e8

Use HasFlag instead of bitwise flag comparison
99ebdab

vbreuss force-pushed the feature/872-set-creation-last-access-and-last-write-times branch from 510c290 to 99ebdabCompare August 26, 2022 10:21

vbreuss requested a review from siprbaum August 26, 2022 10:25

vbreuss added 3 commits August 27, 2022 11:47

also use AdjustTmesin CreateSymbolicLink
3f86970

Consistently store all times in UTC and return the correct `DateTimeK…
6cfbb43
…ind` in the various methods/properties.

Merge branch 'TestableIO:main' into feature/872-set-creation-last-acc…
47894d2
…ess-and-last-write-times

vbreuss mentioned this pull request Aug 31, 2022
feat: Support event callbacks and custom exceptions in MockFileSystem #883
Closed

siprbaum reviewed Sep 2, 2022
View reviewed changes

Comment threadsrc/System.IO.Abstractions.TestingHelpers/MockFile.cs Outdated
Comment threadsrc/System.IO.Abstractions.TestingHelpers/MockFileData.cs
Comment threadsrc/System.IO.Abstractions.TestingHelpers/MockFileStream.cs

vbreuss added 3 commits September 2, 2022 13:48

Fix time adjustments when creating streams according to the behaviour…
e3644d4
… of a real file system

Implement review findings from@siprbaum
03d6d87

Use Flags to detect the correct file access
932c5d6

vbreuss mentioned this pull request Sep 2, 2022
MockFileStreamFactory.Create does not throw correct exceptions #884
Closed

siprbaum suggested changes Sep 10, 2022
View reviewed changes

Comment threadsrc/System.IO.Abstractions.TestingHelpers/MockFileData.cs

vbreuss added 3 commits September 10, 2022 14:45

Merge branch 'TestableIO:main' into feature/872-set-creation-last-acc…
8eedddb
…ess-and-last-write-times

Initialize times in all constructors of MockFileData
815bf81

Merge branch 'TestableIO:main' into feature/872-set-creation-last-acc…
bf41180
…ess-and-last-write-times

fgreinacher reviewed Sep 13, 2022
View reviewed changes

Comment threadsrc/System.IO.Abstractions.TestingHelpers/MockDirectoryInfo.cs

fgreinacher reviewed Sep 13, 2022
View reviewed changes

Comment threadsrc/System.IO.Abstractions.TestingHelpers/MockFileSystem.cs Outdated

fgreinacher reviewed Sep 13, 2022
View reviewed changes

Comment threadsrc/System.IO.Abstractions.TestingHelpers/TimeAdjustments.cs Outdated

vbreussand others added 3 commits September 13, 2022 13:27

Update src/System.IO.Abstractions.TestingHelpers/MockFileSystem.cs
de88c79
Co-authored-by: Florian Greinacher <florian@greinacher.de>

Update src/System.IO.Abstractions.TestingHelpers/TimeAdjustments.cs
477d8ca
Co-authored-by: Florian Greinacher <florian@greinacher.de>

Adjust DateTimeKind.Unspecified
f0bc24e

xtopaz mentioned this pull request Sep 16, 2022
fix: set last access time with unspecified date time kind #879
Closed

fgreinacher changed the title ~~feat: Set Creation, LastAccess and LastWrite time for files~~feat: set Creation, LastAccess and LastWrite time for filesSep 16, 2022

Merge branch 'main' into feature/872-set-creation-last-access-and-las…
7d75b96
…t-write-times

fgreinacher approved these changes Sep 16, 2022
View reviewed changes

mergifyBot merged commit a53bd9a into TestableIO:mainSep 16, 2022

github-actionsBot added the state: released Issues that are released label Nov 18, 2022

This was referenced Jan 7, 2023
chore(deps): update dependency system.io.abstractions to v19 - autoclosed mrudat/UniquePlayer#196
Closed
chore(deps): update dependency system.io.abstractions.testinghelpers to v19 - autoclosed mrudat/UniquePlayer#197
Closed

vbreuss mentioned this pull request Aug 22, 2023
MockFileSystem: IFile.GetLastWriteTimeUtc may return wrong last write time after calling IFileInfo.Open #1029
Closed

vbreuss deleted the feature/872-set-creation-last-access-and-last-write-times branch March 28, 2024 12:46

Uh oh!

Conversation

vbreuss commented Aug 10, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vbreuss commented Aug 11, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vbreuss commented Aug 17, 2022

Uh oh!

fgreinacher commented Aug 17, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fgreinacher left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vbreuss commented Aug 31, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vbreuss commented Sep 2, 2022

Uh oh!

Uh oh!

vbreuss commented Sep 10, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Nov 18, 2022

Uh oh!

github-actionsBot commented Nov 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vbreuss commented Aug 10, 2022•
edited
Loading

vbreuss commented Aug 11, 2022•
edited
Loading

fgreinacher left a comment •
edited
Loading