Uh oh!
There was an error while loading. Please reload this page.
fix: Fixed typos in test names, variables and method parameter name - #944
Merged
Conversation
vbreuss
approved these changes
Feb 9, 2023
vbreuss
left a comment
Member
There was a problem hiding this comment.
Looks good. Thanks @brinkdinges !
fgreinacher
approved these changes
Feb 14, 2023
vbreuss referenced
this pull request
in Testably/Testably.Abstractions
Feb 14, 2023
…19.1.18 (#254) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions) | nuget | patch | `19.1.14` -> `19.1.18` | --- ### Release Notes <details> <summary>TestableIO/System.IO.Abstractions</summary> ### [`v19.1.18`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.1.18) ##### What's Changed - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.16 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/941](https://togithub.com/TestableIO/System.IO.Abstractions/pull/941) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.17 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/945](https://togithub.com/TestableIO/System.IO.Abstractions/pull/945) - chore(deps): update amannn/action-semantic-pull-request action to v5.1.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/946](https://togithub.com/TestableIO/System.IO.Abstractions/pull/946) - fix: Fixed typos in test names, variables and method parameter name by [@​brinkdinges](https://togithub.com/brinkdinges) in [https://github.com/TestableIO/System.IO.Abstractions/pull/944](https://togithub.com/TestableIO/System.IO.Abstractions/pull/944) ##### New Contributors - [@​brinkdinges](https://togithub.com/brinkdinges) made their first contribution in [https://github.com/TestableIO/System.IO.Abstractions/pull/944](https://togithub.com/TestableIO/System.IO.Abstractions/pull/944) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.1.14...v19.1.18 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMzMuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEzMy4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This is addressed in release v19.1.18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While searching for a fix for #942, I noticed a few typos in (mostly) test method names so I fixed them. I didn't change any public methods that had any references.
I kept 'typos' like variable names that consist of multiple words but did not use camelcase, like 'newcontents'.