Uh oh!
There was an error while loading. Please reload this page.
fix: ensure FlushAsync behaves like Flush - #960
Merged
Conversation
Added a replication test for bug #959, which relates to incorrect handling of `MockFileStream.FlushAsync`.
Fixed a bug (#959) related to the `MockFileStream.FlushAsync` method. Added an overwrite that synchronously invokes the internal flush implementation. This resolves the issue where `FlushAsync` wouldn't project the changes to the `Contents` of the underlying file (like `Flush` does).
fgreinacher
self-requested a review
March 11, 2023 15:11
Unit tests were using a `Span<T>` based overload for `Stream.WriteAsync`, which did not exist in old versions of .NET (namely .NET 4). Expanded the call to use an offset and length as required by the old API.
fgreinacher
approved these changes
Mar 13, 2023
fgreinacher
left a comment
Contributor
There was a problem hiding this comment.
Looking great, thanks!
FlushAsync behaves like FlushFlushAsync behaves like Flushvbreuss referenced
this pull request
in Testably/Testably.Abstractions
Apr 9, 2023
…19.2.4 (#281) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions) | nuget | patch | `19.2.1` -> `19.2.4` | --- ### Release Notes <details> <summary>TestableIO/System.IO.Abstractions</summary> ### [`v19.2.4`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.4) ##### What's Changed - fix: make FileSystemStream path argument non-nullable by [@​oreze](https://togithub.com/oreze) in [https://github.com/TestableIO/System.IO.Abstractions/pull/956](https://togithub.com/TestableIO/System.IO.Abstractions/pull/956) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.19 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/958](https://togithub.com/TestableIO/System.IO.Abstractions/pull/958) - fix: ensure `FlushAsync` behaves like `Flush` by [@​cryocz](https://togithub.com/cryocz) in [https://github.com/TestableIO/System.IO.Abstractions/pull/960](https://togithub.com/TestableIO/System.IO.Abstractions/pull/960) ##### New Contributors - [@​oreze](https://togithub.com/oreze) made their first contribution in [https://github.com/TestableIO/System.IO.Abstractions/pull/956](https://togithub.com/TestableIO/System.IO.Abstractions/pull/956) - [@​cryocz](https://togithub.com/cryocz) made their first contribution in [https://github.com/TestableIO/System.IO.Abstractions/pull/960](https://togithub.com/TestableIO/System.IO.Abstractions/pull/960) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.2.1...v19.2.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNjAuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE2MC4wIn0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Valentin Breuß <vbreuss@gmail.com> Co-authored-by: Valentin Breuß <v.breuss@tig.at>
](https://renovatebot.com){kind=link}
This is addressed in release v19.2.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an overwrite for
Stream.FlushAsyncto theMockFileStreamclass, which ensures that the internal flush implementation is called. This wayFlushAsyncwill correctly project the changes to the underlyingMockFile, exactly likeFlushdoes.Closes#959