Skip to content

fix: throw IOException when creating a directory with a conflicting file - #969

Merged
mergify[bot] merged 2 commits into
TestableIO:mainfrom
vbreuss:topic/vb/fix-968
Apr 18, 2023
Merged

fix: throw IOException when creating a directory with a conflicting file#969
mergify[bot] merged 2 commits into
TestableIO:mainfrom
vbreuss:topic/vb/fix-968

Conversation

@vbreuss

@vbreussvbreuss commented Apr 16, 2023

Copy link
Copy Markdown
Member

Fixes#968:
When creating a directory, check if a file with the same name already exists. If so, throw an IOException.

@fgreinacherfgreinacher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify
mergifyBot merged commit 659f7b4 into TestableIO:mainApr 18, 2023
@github-actions

Copy link
Copy Markdown

This is addressed in release v19.2.12.

@github-actionsgithub-actionsBot added the state: released Issues that are released label Apr 18, 2023
@vbreuss
vbreuss deleted the topic/vb/fix-968 branch April 18, 2023 11:36
vbreuss referenced this pull request in Testably/Testably.Abstractions Apr 19, 2023
…19.2.15 (#296)
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
|
[TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions)
| nuget | patch | `19.2.11` -> `19.2.15` |
---
### Release Notes
<details>
<summary>TestableIO/System.IO.Abstractions</summary>
###
[`v19.2.15`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.15)
##### What's Changed
- docs: improve documentation for `FileSystemStream` by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/971](https://togithub.com/TestableIO/System.IO.Abstractions/pull/971)
- fix: update Name of `DirectoryInfo` when using `MoveTo` by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/972](https://togithub.com/TestableIO/System.IO.Abstractions/pull/972)
**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.2.13...v19.2.15
###
[`v19.2.13`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.13)
##### What's Changed
- fix: always keep `FileAttributes.Directory` on directories by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/970](https://togithub.com/TestableIO/System.IO.Abstractions/pull/970)
**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.2.12...v19.2.13
###
[`v19.2.12`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.12)
##### What's Changed
- fix: throw IOException when creating a directory with a conflicting
file by [@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/969](https://togithub.com/TestableIO/System.IO.Abstractions/pull/969)
**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.2.11...v19.2.12
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40OS4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDkuMCJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state: releasedIssues that are released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MockFileSystem.Directory.CreateDirectory should throw IOException if conflicting file exists

3 participants

@vbreuss@fgreinacher@vbtig