Uh oh!
There was an error while loading. Please reload this page.
feat: Add Flush(bool) to FileSystemStream. - #985
Merged
mergify[bot] merged 3 commits intoMay 12, 2023
Merged
Conversation
vbreuss
approved these changes
May 10, 2023
vbreuss
left a comment
Member
There was a problem hiding this comment.
Thanks a lot!
Looks good to me.
Uh oh!
There was an error while loading. Please reload this page.
fgreinacher
approved these changes
May 12, 2023
fgreinacher
left a comment
Contributor
There was a problem hiding this comment.
Awesome, thanks a lot!
This is addressed in release v19.2.25. |
vbreuss referenced
this pull request
in Testably/Testably.Abstractions
May 12, 2023
…19.2.26 (#306) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions) | nuget | patch | `19.2.22` -> `19.2.26` | --- ### Release Notes <details> <summary>TestableIO/System.IO.Abstractions</summary> ### [`v19.2.26`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.26) ##### What's Changed - fix: Refresh FileInfo & DirectoryInfo after adding to MockFileSystem by [@​rcdailey](https://togithub.com/rcdailey) in [https://github.com/TestableIO/System.IO.Abstractions/pull/984](https://togithub.com/TestableIO/System.IO.Abstractions/pull/984) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.2.25...v19.2.26 ### [`v19.2.25`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.25) #### What's Changed - chore(deps): update dependency githubactionstestlogger to v2.1.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/986](https://togithub.com/TestableIO/System.IO.Abstractions/pull/986) - chore(deps): update dependency nerdbank.gitversioning to v3.6.132 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/987](https://togithub.com/TestableIO/System.IO.Abstractions/pull/987) - feat: Add Flush(bool) to FileSystemStream. by [@​gregington](https://togithub.com/gregington) in [https://github.com/TestableIO/System.IO.Abstractions/pull/985](https://togithub.com/TestableIO/System.IO.Abstractions/pull/985) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.2.22...v19.2.25 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43OS4xIiwidXBkYXRlZEluVmVyIjoiMzUuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
vbreuss referenced
this pull request
in Testably/Testably.Abstractions
May 12, 2023
…19.2.26 (#306) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions) | nuget | patch | `19.2.22` -> `19.2.26` | --- ### Release Notes <details> <summary>TestableIO/System.IO.Abstractions</summary> ### [`v19.2.26`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.26) ##### What's Changed - fix: Refresh FileInfo & DirectoryInfo after adding to MockFileSystem by [@​rcdailey](https://togithub.com/rcdailey) in [https://github.com/TestableIO/System.IO.Abstractions/pull/984](https://togithub.com/TestableIO/System.IO.Abstractions/pull/984) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.2.25...v19.2.26 ### [`v19.2.25`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.25) #### What's Changed - chore(deps): update dependency githubactionstestlogger to v2.1.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/986](https://togithub.com/TestableIO/System.IO.Abstractions/pull/986) - chore(deps): update dependency nerdbank.gitversioning to v3.6.132 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/987](https://togithub.com/TestableIO/System.IO.Abstractions/pull/987) - feat: Add Flush(bool) to FileSystemStream. by [@​gregington](https://togithub.com/gregington) in [https://github.com/TestableIO/System.IO.Abstractions/pull/985](https://togithub.com/TestableIO/System.IO.Abstractions/pull/985) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.2.22...v19.2.25 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43OS4xIiwidXBkYXRlZEluVmVyIjoiMzUuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
vbreuss added a commit
to Testably/Testably.Abstractions
that referenced
this pull request
May 12, 2023
Add support for `Flush(bool)` added in TestableIO/System.IO.Abstractions#985 --------- Co-authored-by: Valentin Breuß <v.breuss@tig.at> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileSystemStreamwas missing the implementation ofFileStream.Flush(bool)which allows the caller to specify whetherFlushshould ensure all buffers are written to disk.