Skip to content

fix: error in build pipeline - #720

Merged
vbreuss merged 1 commit into
mainfrom
topic/fix-main-pipeline
Aug 13, 2025
Merged

fix: error in build pipeline#720
vbreuss merged 1 commit into
mainfrom
topic/fix-main-pipeline

Conversation

@vbreuss

@vbreussvbreuss commented Aug 13, 2025

Copy link
Copy Markdown
Member
  • Only write PR.txt when the build runs as part of a pull request
  • Execute the MutationTestsComment in the CI-Analysis step
  • Extract artifacts to separate directories so as not to overwrite the mutation-report.json files

@vbreussvbreuss self-assigned this Aug 13, 2025
CopilotAI review requested due to automatic review settings August 13, 2025 16:37
@vbreussvbreuss added the bug Something isn't working label Aug 13, 2025

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an error in the build pipeline by updating the condition for writing the PR.txt file to only occur during actual pull request builds, rather than checking for a non-null pull request number.

  • Updates the condition from checking if PullRequestNumber is not null to using the IsPullRequest property
  • Adds logging to indicate when the PR.txt file is being written
  • Uses null-safe string conversion for the pull request number

Comment threadPipeline/Build.MutationTests.cs
@github-actions

github-actionsBot commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

Test Results

14 files - 24 14 suites - 24 2m 47s ⏱️ -14s
14 358 tests - 21 14 356 ✅ - 21 2 💤 ±0 0 ❌ ±0 
39 756 runs - 72 39 754 ✅ - 72 2 💤 ±0 0 ❌ ±0 

Results for commit d5d016b. ± Comparison against base commit 6c33916.

This pull request removes 1553 and adds 1532 tests. Note that renamed tests count towards both.
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message0ab3fe55-f191-4da8-aee4-13c1239dbe49")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message15b3f039-856d-4df4-82df-a10eb9e652ed")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message5d9da588-f415-48d6-bdea-a722243e3015")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "message1976e2cd-f7fb-4d19-9927-56a8237021e5")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "message9211ef99-e9f3-4de8-943a-8cc07f37ed13")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "messagecb907f6b-4a24-45a1-9d3b-22300c391fe6")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnore05a8652d-e64a-4b48-85b1-eba1d051a0cc")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnore5914fa12-8623-4ab1-a425-69ad20aa1dbc")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnore78dcb92e-d58a-40a8-b90d-48bae1d77e8f")
aweXpect.Core.Tests.FailTests ‑ Test_ShouldThrowException(reason: "reason365735b3-470a-4a46-9e99-a37e2d4d6db4")
…
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message816237ba-be26-4cb1-ba98-08d813305179")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "messageadb6e52c-9072-4bbf-9fc1-c45378f01e15")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "messaged98b8b22-065e-441e-83c6-30bb8ff25dbd")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "message6978a21e-5ca0-4b28-b19e-a5788424862d")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "messageb6b69f5b-0414-4850-869b-2ef01f06be51")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "messagede3ffddd-7c21-42b1-8ff3-ae1c865f0cb6")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnore5868d19f-ae75-42ce-9b31-6acc5d11f757")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnore69d09761-2b3f-40d6-9462-a2b624e0ea99")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnorefc19f5d1-381a-4fad-9b19-67d15d652216")
aweXpect.Core.Tests.FailTests ‑ Test_ShouldThrowException(reason: "reason2e335c96-03a4-4cad-9ff7-3f50fac51de9")
…

♻️ This comment has been updated with latest results.

@github-actions

github-actionsBot commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

🚀 Benchmark Results

Details

BenchmarkDotNet v0.14.0, Ubuntu 24.04.2 LTS (Noble Numbat)
AMD EPYC 7763, 1 CPU, 4 logical and 2 physical cores
.NET SDK 8.0.413
[Host] : .NET 8.0.19 (8.0.1925.36514), X64 RyuJIT AVX2

Job=InProcess Toolchain=InProcessEmitToolchain IterationCount=15
LaunchCount=1 WarmupCount=10

MethodMeanErrorStdDevGen0Gen1Allocated
Bool_aweXpect183.9 ns0.86 ns0.76 ns0.0281-472 B
Bool_FluentAssertions244.7 ns1.21 ns1.07 ns0.0567-952 B
Bool_TUnit885.8 ns3.58 ns3.18 ns0.1431-2408 B
Equivalency_aweXpect288,209.6 ns1,089.23 ns965.58 ns16.60160.4883284940 B
Equivalency_FluentAssertions2,228,961.6 ns7,966.08 ns7,451.47 ns273.437546.87504584416 B
Equivalency_TUnit676,448.0 ns2,320.58 ns2,057.13 ns51.75782.9297880545 B
Int_GreaterThan_aweXpect209.0 ns0.82 ns0.72 ns0.0467-784 B
Int_GreaterThan_FluentAssertions242.4 ns1.37 ns1.28 ns0.0730-1224 B
Int_GreaterThan_TUnit1,174.3 ns15.26 ns12.74 ns0.1774-2984 B
ItemsCount_AtLeast_aweXpect501.4 ns1.27 ns1.12 ns0.0849-1432 B
ItemsCount_AtLeast_FluentAssertions481.2 ns1.16 ns0.97 ns0.1192-2008 B
ItemsCount_AtLeast_TUnit15,206.8 ns79.68 ns70.63 ns1.6174-27480 B
String_aweXpect344.9 ns2.39 ns2.12 ns0.0672-1128 B
String_FluentAssertions462.8 ns2.04 ns1.70 ns0.1292-2168 B
String_TUnit1,209.0 ns6.50 ns6.08 ns0.1831-3072 B
StringArray_aweXpect1,342.5 ns7.09 ns6.63 ns0.1640-2744 B
StringArray_FluentAssertions1,278.9 ns5.48 ns5.13 ns0.2480-4152 B
StringArray_TUnit3,172.4 ns6.75 ns5.98 ns0.3128-5296 B
StringArrayInAnyOrder_aweXpect1,513.8 ns4.14 ns3.67 ns0.1736-2920 B
StringArrayInAnyOrder_FluentAssertions154,346.4 ns592.94 ns554.63 ns3.4180-63787 B
StringArrayInAnyOrder_TUnit3,773.0 ns14.93 ns13.23 ns0.3853-6488 B

- Only write PR.txt when the build runs as part of a pull request
- Execute the MutationTestsComment in the CI-Analysis step
- Extract artifacts to separate directories so as not to overwrite the mutation-report.json files
@vbreuss
vbreussforce-pushed the topic/fix-main-pipeline branch from ca37acc to d5d016bCompareAugust 13, 2025 17:21
@vbreuss
vbreuss enabled auto-merge (squash) August 13, 2025 17:21
@sonarqubecloud

Copy link
Copy Markdown

@vbreuss
vbreuss merged commit e13592d into mainAug 13, 2025
14 checks passed
@vbreuss
vbreuss deleted the topic/fix-main-pipeline branch August 13, 2025 17:30
github-actionsBot added a commit that referenced this pull request Aug 13, 2025
github-actionsBot added a commit that referenced this pull request Aug 13, 2025
@github-actions

Copy link
Copy Markdown
Contributor

This is addressed in release v2.22.0.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingstate: releasedThe issue is released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vbreuss