fix: negation of Satisfy for collections

[vbreuss]

This PR fixes the negation of the Satisfy constraint for collections and adds comprehensive test coverage for negated assertions. The main issue was that negated collection constraints incorrectly applied grammar negation transformations when building expected messages, leading to confusing output when assertions failed.

Key Changes

• Fixed negation logic in collection constraints by removing incorrect grammar negation calls
• Added comprehensive test suites for negated collection count assertions (HasCount, AtLeast, MoreThan, etc.)
• Restructured test files to include both regular and negated test classes
• Also add some missing test cases for string-based collection operations (AsPrefix, AsSuffix)

[Copilot]

Pull Request Overview

This PR fixes the negation of the Satisfy constraint for collections and adds comprehensive test coverage for negated assertions. The main issue was that negated collection constraints incorrectly applied grammar negation transformations when building expected messages, leading to confusing output when assertions failed.

Key Changes

• Fixed negation logic in collection constraints by removing incorrect grammar negation calls
• Added comprehensive test suites for negated collection count assertions (HasCount, AtLeast, MoreThan, etc.)
• Restructured test files to include both regular and negated test classes
• Added missing test coverage for string-based collection operations (AsPrefix, AsSuffix)

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
Source/aweXpect/That/Collections/ThatEnumerable.cs	Fixed negation logic by removing Grammars.Negate() calls in message formatting
Source/aweXpect/That/Collections/ThatAsyncEnumerable.cs	Applied same negation fixes for async enumerables and simplified constraint inheritance
Source/aweXpect/That/Collections/EnumerableQuantifier.All.cs	Added special handling for negated "All" quantifier results
Tests/aweXpect.Tests/Collections/ThatEnumerable.HasCount.*.Tests.cs	Restructured test files with nested classes for regular and negated tests
Tests/aweXpect.Tests/Collections/ThatAsyncEnumerable.HasCount.*.Tests.cs	Applied same test restructuring for async enumerable tests
Tests/aweXpect.Tests/Collections/ThatEnumerable.All.Satisfy.Tests.cs	Added comprehensive negated test coverage
Tests/aweXpect.Tests/Collections/ThatEnumerable.Contains.Tests.cs	Added missing test cases for AsPrefix and AsSuffix operations

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

14 files - 24 14 suites - 24 4m 27s ⏱️ +36s
17 340 tests + 9 17 337 ✅ + 9 3 💤 ±0 0 ❌ ±0 
48 684 runs +27 48 679 ✅ +27 5 💤 ±0 0 ❌ ±0 

Results for commit 00ba78f. ± Comparison against base commit a18e70c.

This pull request removes 1645 and adds 1654 tests. Note that renamed tests count towards both.

aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message05531159-5b5d-4304-afd0-22111eec24ed")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message2f55b524-454f-4be2-a167-bac1343f0d68")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "messageeb174bb8-e5bd-4741-99c8-1d634cf02720")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "message3c5f81d0-8ad6-4cb2-b0f5-431532dc1084")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "message3d939b11-ae5f-4f5c-aac0-18e71497e5ae")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "messagef903b3c0-aaaa-4cf9-933d-304af81062fb")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnore93c4be95-e863-41e9-88c7-2c26152284a8")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnoreb3e5a924-c6ab-4a4b-aeb8-84cc2c20352d")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnorecd350bec-bef5-4833-98bf-7b0ca1bf3475")
aweXpect.Core.Tests.FailTests ‑ Test_ShouldThrowException(reason: "reason855f9f3d-41cf-4ee2-97c9-d91c8762d960")
…

aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message673b6a64-6b9c-44bc-bdfb-7d6127b714a2")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "messagef226b5fa-0158-47cb-83a2-f5d850a35123")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "messagef354d69d-ba14-4819-b6e0-0cc0512aeed2")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "messageaba413bc-f730-4170-a7fa-68a93e943837")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "messagee1ed28d2-9fa4-4e96-ab06-557a806dcd4c")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "messagee9d6baf7-acb5-44e5-b57c-b6aae2d68a28")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnore5a1abee4-552a-402f-8858-270c509451ba")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnoreb973f206-a5f7-4ab5-bd5f-6744cb12618d")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnorebfc9752f-837e-4d32-a5b3-db6279e98385")
aweXpect.Core.Tests.FailTests ‑ Test_ShouldThrowException(reason: "reason4aa7f177-df3e-4315-a127-9ab8b062edc1")
…

[github-actions]

🚀 Benchmark Results

Details

BenchmarkDotNet v0.14.0, Ubuntu 24.04.3 LTS (Noble Numbat)

AMD EPYC 7763, 1 CPU, 4 logical and 2 physical cores

.NET SDK 8.0.413

[Host] : .NET 8.0.19 (8.0.1925.36514), X64 RyuJIT AVX2
Job=InProcess Toolchain=InProcessEmitToolchain IterationCount=15

LaunchCount=1 WarmupCount=10

Method	Mean	Error	StdDev	Gen0	Gen1	Allocated
Bool_aweXpect	215.6 ns	4.18 ns	3.70 ns	0.0300	-	504 B
Bool_FluentAssertions	259.0 ns	5.32 ns	4.97 ns	0.0567	-	952 B
Bool_TUnit	957.0 ns	18.68 ns	17.47 ns	0.1431	-	2408 B
Equivalency_aweXpect	327,129.4 ns	1,636.78 ns	1,450.96 ns	16.6016	0.4883	285044 B
Equivalency_FluentAssertions	2,375,419.2 ns	36,999.37 ns	34,609.23 ns	273.4375	46.8750	4584416 B
Equivalency_TUnit	683,358.4 ns	5,942.66 ns	5,268.02 ns	51.7578	2.9297	880545 B
Int_GreaterThan_aweXpect	249.4 ns	6.75 ns	5.99 ns	0.0486	-	816 B
Int_GreaterThan_FluentAssertions	281.6 ns	7.11 ns	6.65 ns	0.0730	-	1224 B
Int_GreaterThan_TUnit	1,253.5 ns	34.21 ns	32.00 ns	0.1774	-	2984 B
ItemsCount_AtLeast_aweXpect	501.3 ns	7.19 ns	6.73 ns	0.0868	-	1464 B
ItemsCount_AtLeast_FluentAssertions	512.2 ns	11.96 ns	11.19 ns	0.1192	-	2008 B
ItemsCount_AtLeast_TUnit	17,862.6 ns	193.88 ns	181.35 ns	1.6174	-	27480 B
String_aweXpect	460.2 ns	7.96 ns	7.45 ns	0.0734	-	1232 B
String_FluentAssertions	493.9 ns	12.69 ns	11.25 ns	0.1287	-	2168 B
String_TUnit	1,269.1 ns	16.48 ns	15.42 ns	0.1831	-	3072 B
StringArray_aweXpect	1,820.3 ns	14.53 ns	13.59 ns	0.1698	-	2856 B
StringArray_FluentAssertions	1,400.1 ns	20.02 ns	18.73 ns	0.2480	-	4152 B
StringArray_TUnit	3,379.5 ns	44.17 ns	41.32 ns	0.3128	-	5296 B
StringArrayInAnyOrder_aweXpect	2,290.8 ns	21.44 ns	20.06 ns	0.1793	-	3048 B
StringArrayInAnyOrder_FluentAssertions	152,840.7 ns	985.68 ns	922.01 ns	3.4180	-	63787 B
StringArrayInAnyOrder_TUnit	4,031.3 ns	43.21 ns	40.42 ns	0.3815	-	6488 B

[github-actions]

👽 Mutation Results

aweXpect

Details

File	Score	Killed	Survived	Timeout	No Coverage	Ignored	Compile Errors	Total Detected	Total Undetected	Total Mutants
That/Collections/EnumerableQuantifier.All.cs	100.00%	24	0	1	0	7	13	25	0	45
That/Collections/EnumerableQuantifier.MoreThan.cs	100.00%	25	0	1	0	7	12	26	0	45
That/Collections/ThatAsyncEnumerable.cs	77.82%	204	23	3	36	84	167	207	59	517
That/Collections/ThatEnumerable.cs	82.49%	308	9	3	57	113	262	311	66	752

The final mutation score is 81.99%

Coverage Thresholds: high:80 low:60 break:0

aweXpect.Core

Details

File	Score	Killed	Survived	Timeout	No Coverage	Ignored	Compile Errors	Total Detected	Total Undetected	Total Mutants
Delegates/ThatDelegate.WithoutValue.DoesNotThrow.cs	100.00%	19	0	0	0	8	6	19	0	33

The final mutation score is 100.00%

Coverage Thresholds: high:80 low:60 break:0

[github-actions]

This is addressed in release v2.23.0.