Uh oh!
There was an error while loading. Please reload this page.
Ensure navigation title steps actually check the navigation title - #25
Merged
MichaelBuckley merged 2 commits intoJun 13, 2014
Merged
Conversation
Previously all navigation items and subclasses matched, thus the back button text could match. Conflicts: gem/lib/frank-cucumber/core_frank_steps.rb
joemasilotti
commented
Jun 13, 2014
ContributorAuthor
MichaelBuckley added a commit
that referenced
this pull request
Jun 13, 2014
Ensure navigation titles are actually the title
MichaelBuckley
commented
Jun 13, 2014
Contributor
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously all navigation items and subclasses matched, thus the back button text could match. This only checks the navigation item crossing over the middle x pixel of the navigation bar.