Skip to content

fix(): dynamicAnchor memory leak#767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agviegas merged 1 commit into from
Jul 15, 2026
Merged

fix(): dynamicAnchor memory leak #767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/core/src/core/Worlds/src/simple-world.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,7 @@ export class SimpleWorld<
} else {
container.removeEventListener("pointerdown", this.onPointerDown);
}
this._dynamicAnchor = value;
}

get dynamicAnchor() {
Expand DownExpand Up@@ -234,6 +235,13 @@ export class SimpleWorld<
this.enabled = false;
this.isDisposing = true;

// Remove the dynamic anchoring listener before the renderer is disposed
const container = this.renderer?.three.domElement.parentElement;
if (container) {
container.removeEventListener("pointerdown", this.onPointerDown);
}
this._dynamicAnchor = false;

this.scene.onWorldChanged.trigger({ world: this, action: "removed" });
this.camera.onWorldChanged.trigger({ world: this, action: "removed" });
if (this.renderer) {
Expand Down