Skip to content

🧹 Remove hardcoded API URL fallback and add environment validation#7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidraehles merged 3 commits into from
Feb 18, 2026
Merged

🧹 Remove hardcoded API URL fallback and add environment validation #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4528eac
chore: remove hardcoded API URL fallback and add environment validation
google-labs-jules[bot] Feb 18, 2026
9ff4730
fix: address review feedback - remove unused expect import from test …
Feb 18, 2026
5b0a3c1
chore: address PR feedback - remove unused expect import from test setup
google-labs-jules[bot] Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/.env.example
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
VITE_API_URL=http://localhost:3000
6 changes: 5 additions & 1 deletion frontend/src/services/api.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,11 @@

import type { EncryptedNote, LoginCredentials, RegisterCredentials, User } from '../models/types';

const API_BASE_URL = import.meta.env.VITE_API_URL || 'http://localhost:3000';
const API_BASE_URL = import.meta.env.VITE_API_URL;

if (!API_BASE_URL) {
throw new Error('VITE_API_URL environment variable is not defined');
}

class ApiClient {
private baseUrl: string;
Expand Down
5 changes: 4 additions & 1 deletion frontend/src/test/setup.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,10 @@
* Test setup file for Vitest
*/

import { expect, afterEach } from 'vitest';
import { afterEach, vi } from 'vitest';

// Mock environment variables
vi.stubEnv('VITE_API_URL', 'http://localhost:3000');
import { cleanup } from '@testing-library/react';
import '@testing-library/jest-dom';

Expand Down