Skip to content

FindSecondLargestElement: Support negative numbers#1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 2 commits into from
Jun 3, 2022
Merged

FindSecondLargestElement: Support negative numbers #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ba0b26
FindSecondLargestElement: Support negative numbers
appgurueu Jun 3, 2022
d75a323
Updated Documentation in README.md
Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions DIRECTORY.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -142,6 +142,7 @@
* [BinaryExponentiationRecursive](Maths/BinaryExponentiationRecursive.js)
* [BisectionMethod](Maths/BisectionMethod.js)
* [CheckKishnamurthyNumber](Maths/CheckKishnamurthyNumber.js)
* [CollatzSequence](Maths/CollatzSequence.js)
* [Coordinate](Maths/Coordinate.js)
* [CoPrimeCheck](Maths/CoPrimeCheck.js)
* [DecimalExpansion](Maths/DecimalExpansion.js)
Expand All@@ -159,13 +160,15 @@
* [FigurateNumber](Maths/FigurateNumber.js)
* [FindHcf](Maths/FindHcf.js)
* [FindLcm](Maths/FindLcm.js)
* [FindMaxRecursion](Maths/FindMaxRecursion.js)
* [FindMin](Maths/FindMin.js)
* [FindMinIterator](Maths/FindMinIterator.js)
* [GetEuclidGCD](Maths/GetEuclidGCD.js)
* [GridGet](Maths/GridGet.js)
* [IsDivisible](Maths/IsDivisible.js)
* [IsEven](Maths/IsEven.js)
* [IsOdd](Maths/IsOdd.js)
* [IsPronic](Maths/IsPronic.js)
* [LeapYear](Maths/LeapYear.js)
* [LinearSieve](Maths/LinearSieve.js)
* [LucasSeries](Maths/LucasSeries.js)
Expand DownExpand Up@@ -197,6 +200,7 @@
* [SquareRoot](Maths/SquareRoot.js)
* [SumOfDigits](Maths/SumOfDigits.js)
* [SumOfGeometricProgression](Maths/SumOfGeometricProgression.js)
* [TwinPrime](Maths/TwinPrime.js)
* [Volume](Maths/Volume.js)
* [WhileLoopFactorial](Maths/WhileLoopFactorial.js)
* [ZellersCongruenceAlgorithm](Maths/ZellersCongruenceAlgorithm.js)
Expand Down
2 changes: 1 addition & 1 deletion Sorts/FindSecondLargestElement.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@

const secondLargestElement = (array) => {
const largestElement = Math.max(...array)
Comment thread
raklaptudirm marked this conversation as resolved.
let element = 0
let element = -Number.MAX_VALUE

for (let i = 0; i < array.length; i++) {
if (element < array[i] && array[i] !== largestElement) {
Expand Down