`Fibonacci.js` overhaul by Rudxain · Pull Request #1049 · TheAlgorithms/JavaScript

Rudxain · 2022-06-21T17:38:51Z

Added BigInt support to FibonacciMatrixExpo, Identity, matrixMultiply, and matrixExpo. And added the extension to negative domain for all fns in that file. And added a generator function example. Also corrected indices to return 0 if the input arg is 0 (because that's the 0th Fib).
Fixes: #1047

know more

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
All new JavaScript files are placed inside an existing directory.
All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Also added support to `Identity`, `matrixMultiply`, and `matrixExpo`

lgtm-com · 2022-06-21T18:13:42Z

This pull request introduces 1 alert when merging 33df079 into 95a8ec0 - view on LGTM.com

new alerts:

1 for Useless comparison test

lgtm-com · 2022-06-21T18:19:03Z

This pull request introduces 1 alert when merging f4f1d53 into 95a8ec0 - view on LGTM.com

new alerts:

1 for Useless comparison test

lgtm-com · 2022-06-21T18:28:34Z

This pull request introduces 1 alert when merging 2bcbc58 into 95a8ec0 - view on LGTM.com

new alerts:

1 for Useless comparison test

lgtm-com · 2022-06-21T18:33:59Z

This pull request introduces 1 alert when merging 3d865f3 into 95a8ec0 - view on LGTM.com

new alerts:

1 for Useless comparison test

lgtm-com · 2022-06-21T18:40:06Z

This pull request introduces 1 alert when merging 0dc81a8 into 95a8ec0 - view on LGTM.com

new alerts:

1 for Useless comparison test

lgtm-com · 2022-06-21T18:52:22Z

This pull request introduces 1 alert when merging 1f61f51 into 95a8ec0 - view on LGTM.com

new alerts:

1 for Useless comparison test

lgtm-com · 2022-06-21T19:07:36Z

This pull request introduces 1 alert when merging b2101fc into 95a8ec0 - view on LGTM.com

new alerts:

1 for Useless comparison test

lgtm-com · 2022-06-21T19:17:39Z

This pull request introduces 1 alert when merging c5fe0b5 into 95a8ec0 - view on LGTM.com

new alerts:

1 for Useless comparison test

This wasn't originally part of the PR, but I thought it would be good to add

lgtm-com · 2022-06-21T19:42:25Z

This pull request introduces 3 alerts when merging 787fd75 into 95a8ec0 - view on LGTM.com

new alerts:

1 for Expression has no effect
1 for Assignment to property of primitive value
1 for Useless comparison test

lgtm-com · 2022-06-21T19:47:24Z

This pull request introduces 3 alerts when merging 028ebe9 into 95a8ec0 - view on LGTM.com

new alerts:

1 for Expression has no effect
1 for Assignment to property of primitive value
1 for Useless comparison test

lgtm-com · 2022-06-21T20:01:55Z

This pull request introduces 3 alerts when merging 69bbe51 into 95a8ec0 - view on LGTM.com

new alerts:

1 for Expression has no effect
1 for Assignment to property of primitive value
1 for Useless comparison test

Rudxain · 2022-06-21T20:09:17Z

1 for Assignment to property of primitive value

~~lol, the bot can't recognize the destructuring assignment syntax~~

My bad, I didn't recognize that the array literal was interpreted as subscript, lol

lgtm-com · 2022-06-21T20:15:15Z

This pull request introduces 3 alerts when merging 82861ef into 95a8ec0 - view on LGTM.com

new alerts:

1 for Expression has no effect
1 for Assignment to property of primitive value
1 for Useless comparison test

Rudxain · 2022-06-21T20:36:55Z

I tried removing the trailing whitespace, but somehow I can't find them. It seems those are control chars.
Update: Not even VScode can find them. I activated control char rendering and whitespace rendering, no results. I clicked the "Remove all trailing whitespace" option, but absolutely nothing changed. This seems to be a bug

raklaptudirm · 2022-06-22T03:47:54Z

Use standard.js to style your code and remove trailing whitespace. Make sure to read CONTRIBUTING.md before making any contributions.

Rudxain · 2022-06-22T04:45:55Z

Make sure to read CONTRIBUTING.md

I already did it, many times, and thoroughly. I just prefer to fix style errors manually. But it seems the only solution now is to use SJS. I'll install NPM & Node now

Rudxain · 2022-06-22T05:39:40Z

Wait, now I read the problem is in Fibonacci.test.js, not Fibonacci.js 🤦‍♂️. Fixing now

appgurueu

Definitely a significant improvement. I've got some minor comments regarding consistency.

Rudxain added 2 commits June 21, 2022 13:35

Added BigInt support to FibonacciMatrixExpo
398854c
Also added support to `Identity`, `matrixMultiply`, and `matrixExpo`

Fixed style
ea39661

appgurueu added feature Adds a new feature algorithm Adds or improves an algorithm labels Jun 21, 2022

Added negatives support to every fn
33df079

Fixed bug
f4f1d53

Added all missing tests
2bcbc58

Splitted BigInt & Number tests
3d865f3

Shortened sign to sgn in most (not all) places
0dc81a8

Fixed indexing
1f61f51

Rudxain added 3 commits June 21, 2022 15:00

Fixed bug at FDPWR
7090d5a

Fixed FRDP
03ed1f8

Fixed F iter
b2101fc

Rudxain changed the title ~~Added BigInt support to FibonacciMatrixExpo~~Add BigInt support to FibonacciMatrixExpo and negatives for the entire Fibonacci.jsJun 21, 2022

Rudxain changed the title ~~Add BigInt support to FibonacciMatrixExpo and negatives for the entire Fibonacci.js~~Add BigInt & negative support to Fibonacci.jsJun 21, 2022

Fixed FRDP again
c5fe0b5

Added FibonacciGenerator
787fd75
This wasn't originally part of the PR, but I thought it would be good to add

Rudxain added 2 commits June 21, 2022 15:44

Added tests for FibonacciGenerator
c11856b

More consistent test
028ebe9

Rudxain changed the title ~~Add BigInt & negative support to Fibonacci.js~~Add BigInt & negative support to Fibonacci.js, also generator fnJun 21, 2022

Rudxain changed the title ~~Add BigInt & negative support to Fibonacci.js, also generator fn~~Fibonacci.js overhaulJun 21, 2022

Fixed Fib recursive
6f0de19

Explicitly using negative 0
82861ef

Rudxain added 3 commits June 21, 2022 16:16

Fixed errors
83afc56

Fixed part of style
a034743

Fixed style
cdbf5ff

Rudxain marked this pull request as ready for review June 21, 2022 20:37

Rudxain requested review from appgurueu and raklaptudirm as code owners June 21, 2022 20:37

raklaptudirm added the code style issue Failing style checks label Jun 22, 2022

Ran npx standard --fix Fibonacci.js
79d4c47

Removed trailing space
42d3ae4

raklaptudirm removed the code style issue Failing style checks label Jun 22, 2022

raklaptudirm previously approved these changes Jun 26, 2022
View reviewed changes

appgurueu previously approved these changes Jun 26, 2022
View reviewed changes

Comment threadMaths/Fibonacci.js Outdated
Comment threadMaths/Fibonacci.js Outdated
Comment threadMaths/Fibonacci.js Outdated

Update Fibonacci.js
21ff3fd

Rudxain dismissed stale reviews from appgurueu and raklaptudirm via 21ff3fdJune 26, 2022 18:01

Update Fibonacci.js
81e64a4

appgurueu approved these changes Jun 26, 2022
View reviewed changes

raklaptudirm approved these changes Jun 27, 2022
View reviewed changes

raklaptudirm merged commit 1b64ba6 into TheAlgorithms:masterJun 27, 2022

Rudxain deleted the patch-2 branch June 27, 2022 04:43

Uh oh!

Uh oh!

Conversation

Rudxain commented Jun 21, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

lgtm-comBot commented Jun 21, 2022

Uh oh!

lgtm-comBot commented Jun 21, 2022

Uh oh!

lgtm-comBot commented Jun 21, 2022

Uh oh!

lgtm-comBot commented Jun 21, 2022

Uh oh!

lgtm-comBot commented Jun 21, 2022

Uh oh!

lgtm-comBot commented Jun 21, 2022

Uh oh!

lgtm-comBot commented Jun 21, 2022

Uh oh!

lgtm-comBot commented Jun 21, 2022

Uh oh!

lgtm-comBot commented Jun 21, 2022

Uh oh!

lgtm-comBot commented Jun 21, 2022

Uh oh!

lgtm-comBot commented Jun 21, 2022

Uh oh!

Rudxain commented Jun 21, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-comBot commented Jun 21, 2022

Uh oh!

Rudxain commented Jun 21, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raklaptudirm commented Jun 22, 2022

Uh oh!

Rudxain commented Jun 22, 2022

Uh oh!

Rudxain commented Jun 22, 2022

Uh oh!

appgurueu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Rudxain commented Jun 21, 2022•
edited
Loading

Rudxain commented Jun 21, 2022•
edited
Loading

Rudxain commented Jun 21, 2022•
edited
Loading