Skip to content

Edit Perfect{Square, Cube} - #1071

Merged
raklaptudirm merged 11 commits into
TheAlgorithms:masterfrom
Rudxain:patch-1
Aug 12, 2022
Merged

Edit Perfect{Square, Cube}#1071
raklaptudirm merged 11 commits into
TheAlgorithms:masterfrom
Rudxain:patch-1

Conversation

@Rudxain

@RudxainRudxain commented Jul 28, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Open in Gitpodknow more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Rudxain
Rudxain marked this pull request as ready for review July 28, 2022 17:39
appgurueu
appgurueu previously approved these changes Jul 28, 2022
View reviewed changes
raklaptudirm
raklaptudirm requested changes Jul 29, 2022
View reviewed changes
Comment threadMaths/PerfectCube.js Outdated
@Rudxain
Merge branch 'TheAlgorithms:master' into patch-1
188a16e
@Rudxain
Update PerfectCube.js
c1210aa
Now `isInt` is replaced by `isFinite`, because `isInt` is a redundant check
@Rudxain
Update PerfectCube.js
2491d25
Remove dot
@Rudxain
Parity between PerfectSquare and PerfectCube
7d0e2db
@Rudxain
Update PerfectSquare.test.js
cc4e44e
Fixed the old copy-paste error that said "cube" instead of "square". And added `Infinity` test
@RudxainRudxain changed the title Complete PerfectCubeFix Perfect{Square, Cube}Aug 7, 2022
@RudxainRudxain changed the title Fix Perfect{Square, Cube}Edit Perfect{Square, Cube}Aug 11, 2022
appgurueu
appgurueu approved these changes Aug 12, 2022
View reviewed changes

@appgurueuappgurueu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@appgurueuappgurueu added the feature Adds a new feature label Aug 12, 2022
@raklaptudirm
raklaptudirm merged commit 9790468 into TheAlgorithms:masterAug 12, 2022
@Rudxain
Rudxain deleted the patch-1 branch August 12, 2022 18:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueuappgurueuappgurueu approved these changes
@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees

No one assigned

Labels

featureAdds a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rudxain@appgurueu@raklaptudirm