Skip to content

add: countSubstrings function implementation - #1091

Merged
raklaptudirm merged 3 commits into
TheAlgorithms:masterfrom
ajinkyac03:develop
Sep 7, 2022
Merged

add: countSubstrings function implementation#1091
raklaptudirm merged 3 commits into
TheAlgorithms:masterfrom
ajinkyac03:develop

Conversation

@ajinkyac03

Copy link
Copy Markdown
Contributor

Open in Gitpodknow more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not

Fixes#1090

Comment threadString/CountSubstrings.js Outdated
Comment threadString/CountSubstrings.js Outdated
Comment threadString/CountSubstrings.js Outdated

@appgurueuappgurueu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about overlapping substrings? I might expect countSubstrings("aaa", "aa") to be 2. Currently this is undocumented & untested behavior.

@appgurueuappgurueu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Runtime is O(n²) due to the naive implementation.

@appgurueuappgurueu added the algorithm Adds or improves an algorithm label Sep 6, 2022
@raklaptudirmraklaptudirm changed the title Added countSubstrings function implementation.add: countSubstrings function implementation.Sep 7, 2022
@raklaptudirmraklaptudirm changed the title add: countSubstrings function implementation.add: countSubstrings function implementationSep 7, 2022
@raklaptudirm
raklaptudirm merged commit 6c718c0 into TheAlgorithms:masterSep 7, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

algorithmAdds or improves an algorithm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Count occurrences of substring in a string function implementation not there

3 participants

@ajinkyac03@appgurueu@raklaptudirm