Skip to content

GitHub Actions: Test on the current version of Node.js - #1657

Merged
appgurueu merged 4 commits into
masterfrom
Node.js-v22
May 17, 2024
Merged

GitHub Actions: Test on the current version of Node.js#1657
appgurueu merged 4 commits into
masterfrom
Node.js-v22

Conversation

@cclauss

Copy link
Copy Markdown
Member

Open in Gitpodknow more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (314144f) to head (5e8b86b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #1657 +/- ##
==========================================
- Coverage 84.09% 84.07% -0.03% 
==========================================
Files 376 376 Lines 19664 19670 +6 Branches 2911 2911 ==========================================
+ Hits 16537 16538 +1 - Misses 3127 3132 +5 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cclauss

cclauss commented May 16, 2024

Copy link
Copy Markdown
MemberAuthor

@appgurueu Your review, please.

@appgurueuappgurueu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay

@appgurueu
appgurueu merged commit cc1e1dc into masterMay 17, 2024
@appgurueu
appgurueu deleted the Node.js-v22 branch May 17, 2024 15:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cclauss@codecov-commenter@appgurueu@raklaptudirm