Uh oh!
There was an error while loading. Please reload this page.
Add tests for Project Euler Problem 5 + minor refactor - #1691
Conversation
…hrown error in case of invalid input
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #1691 +/- ##
==========================================
+ Coverage 84.65% 84.76% +0.10%
==========================================
Files 378 378 Lines 19744 19742 -2 Branches 2952 2956 +4 ==========================================
+ Hits 16715 16735 +20 + Misses 3029 3007 -22 ☔ View full report in Codecov by Sentry. |
pomkarnath98
commented
Sep 28, 2024
@raklaptudirm@appgurueu I have formatted the code with Prettier. But the Codecov report says, |
appgurueu
commented
Oct 2, 2024
As the codecov report shows, the trivial error check is not tested (see https://app.codecov.io/gh/TheAlgorithms/JavaScript/pull/1691/blob/Project-Euler/Problem005.js). I would probably just remove it. |
pomkarnath98
commented
Oct 3, 2024
@appgurueu@raklaptudirm I think this PR now can be reviewed and merged. |
Uh oh!
There was an error while loading. Please reload this page.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.