Skip to content

add : trapped water program under dynamic programming - #10027

Merged
cclauss merged 29 commits into
TheAlgorithms:masterfrom
kosuri-indu:add/trapped_water_problem
Oct 7, 2023
Merged

add : trapped water program under dynamic programming#10027
cclauss merged 29 commits into
TheAlgorithms:masterfrom
kosuri-indu:add/trapped_water_problem

Conversation

@kosuri-indu

@kosuri-indukosuri-indu commented Oct 7, 2023

Copy link
Copy Markdown
Contributor

Describe your change:

This PR adds the trapped_water program under the dynamic programming folder
Fixes#10026

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 7, 2023
@kosuri-indukosuri-indu changed the title to add the trapped water programadd : trapped water program under dynamic programmingOct 7, 2023
@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 7, 2023
@algorithms-keeperalgorithms-keeperBot added the require type hints https://docs.python.org/3/library/typing.html label Oct 7, 2023
algorithms-keeper[bot]
algorithms-keeperBot reviewed Oct 7, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threaddynamic_programming/trapped_water.py Outdated
algorithms-keeper[bot]
algorithms-keeperBot reviewed Oct 7, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threaddynamic_programming/trapped_water.py Outdated
cclauss
cclauss reviewed Oct 7, 2023
View reviewed changes
Comment threaddynamic_programming/trapped_water.py Outdated
@algorithms-keeperalgorithms-keeperBot removed the require type hints https://docs.python.org/3/library/typing.html label Oct 7, 2023
pre-commit-ciBotand others added 2 commits October 7, 2023 16:36
cclauss
cclauss reviewed Oct 7, 2023
View reviewed changes
Comment threaddynamic_programming/trapped_water.py Outdated
cclauss
cclauss reviewed Oct 7, 2023
View reviewed changes
Comment threaddynamic_programming/trapped_water.py Outdated
@kosuri-indu@cclauss
Update dynamic_programming/trapped_water.py
3f9951d
Co-authored-by: Christian Clauss <cclauss@me.com>
@kosuri-indu

kosuri-indu commented Oct 7, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@cclauss enumerate is showing an error

cclauss
cclauss reviewed Oct 7, 2023
View reviewed changes
Comment threaddynamic_programming/trapped_water.py
cclauss
cclauss requested changes Oct 7, 2023
View reviewed changes
Comment threaddynamic_programming/trapped_water.py Outdated
@algorithms-keeperalgorithms-keeperBot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 7, 2023
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 7, 2023
cclauss
cclauss reviewed Oct 7, 2023
View reviewed changes
Comment threaddynamic_programming/trapped_water.py Outdated
cclauss
cclauss reviewed Oct 7, 2023
View reviewed changes
Comment threaddynamic_programming/trapped_water.py Outdated
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 7, 2023
cclauss
cclauss approved these changes Oct 7, 2023
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Final edits: f17ff76

@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 7, 2023
@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 7, 2023
@kosuri-indu

kosuri-indu commented Oct 7, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss
Thank you for the edits and constant reviewing :) !
and how to get this PR merged after all the checks are done?

Have a good day!

@cclauss
cclauss merged commit 6029173 into TheAlgorithms:masterOct 7, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 7, 2023
tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request Oct 8, 2023
@kosuri-indu@pre-commit-ci
@cclauss@tianyizheng02
add : trapped water program under dynamic programming (TheAlgorithms#…
93d1342
…10027)
* to add the trapped water program
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* to make changes for error : B006
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* to make changes for error : B006
* to make changes for error : B006
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* to make changes in doctest
* to make changes in doctest
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update dynamic_programming/trapped_water.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/trapped_water.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* to make changes in parameters
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* to make changes in parameters
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update dynamic_programming/trapped_water.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* to make changes in parameters
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* for negative heights
* Update dynamic_programming/trapped_water.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* to remove falsy
* Final edits
* tuple[int, ...]
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
+1 more reviewer
@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Add] : trapped water program by using DYNAMIC PROGRAMMING

2 participants

@kosuri-indu@cclauss