Skip to content

Fix bug and edit doctests for infix_to_prefix_conversion - #10259

Merged
cclauss merged 6 commits into
TheAlgorithms:masterfrom
hollowcrust:patch-2
Oct 11, 2023
Merged

Fix bug and edit doctests for infix_to_prefix_conversion#10259
cclauss merged 6 commits into
TheAlgorithms:masterfrom
hollowcrust:patch-2

Conversation

@hollowcrust

@hollowcrusthollowcrust commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

Describe your change:

Fixes#10063 and #10095.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 11, 2023
@hollowcrusthollowcrust mentioned this pull request Oct 11, 2023
Closed
14 tasks
cclauss
cclauss reviewed Oct 11, 2023
View reviewed changes
Comment threaddata_structures/stacks/infix_to_prefix_conversion.py Outdated
@cclauss

cclauss commented Oct 11, 2023

Copy link
Copy Markdown
Member

Did the previous pull request have other enhancements?

@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023
cclauss
cclauss reviewed Oct 11, 2023
View reviewed changes
Comment threaddata_structures/stacks/infix_to_prefix_conversion.py Outdated
@hollowcrust

hollowcrust commented Oct 11, 2023

Copy link
Copy Markdown
ContributorAuthor

Yes, I just brought the enhancements from the old PR.

@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 11, 2023
cclauss
cclauss reviewed Oct 11, 2023
View reviewed changes
Comment threaddata_structures/stacks/infix_to_prefix_conversion.py Outdated
@algorithms-keeperalgorithms-keeperBot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 11, 2023
cclauss
cclauss approved these changes Oct 11, 2023
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks massively.

@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023
@cclauss
cclauss merged commit 672fda9 into TheAlgorithms:masterOct 11, 2023
@hollowcrust

hollowcrust commented Oct 11, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks a lot for your help as well!

@hollowcrust
hollowcrust deleted the patch-2 branch October 11, 2023 14:41
@hollowcrust
hollowcrust restored the patch-2 branch October 11, 2023 14:43
@hollowcrust
hollowcrust deleted the patch-2 branch October 11, 2023 14:43
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

tests are failingDo not merge until tests pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hollowcrust@cclauss