Skip to content

Adding doctests in simpson_rule.py - #10269

Merged
cclauss merged 23 commits into
TheAlgorithms:masterfrom
AasheeshLikePanner:simpson_rule_doctests
Oct 11, 2023
Merged

Adding doctests in simpson_rule.py#10269
cclauss merged 23 commits into
TheAlgorithms:masterfrom
AasheeshLikePanner:simpson_rule_doctests

Conversation

@AasheeshLikePanner

@AasheeshLikePannerAasheeshLikePanner commented Oct 11, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

Adding doctests in simpson_rule.py

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
    Improve our test coverage #9943

@algorithms-keeperalgorithms-keeperBot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 11, 2023
@AasheeshLikePannerAasheeshLikePanner mentioned this pull request Oct 11, 2023
Closed
cclauss
cclauss reviewed Oct 11, 2023
View reviewed changes
Comment threadmaths/simpson_rule.py
cclauss
cclauss reviewed Oct 11, 2023
View reviewed changes
Comment threadmaths/simpson_rule.py Outdated
AasheeshLikePannerand others added 2 commits October 11, 2023 16:59
@AasheeshLikePanner@cclauss
Update maths/simpson_rule.py
7c4e6c7
Co-authored-by: Christian Clauss <cclauss@me.com>
@AasheeshLikePanner@cclauss
Update maths/simpson_rule.py
3412f56
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeperalgorithms-keeperBot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 11, 2023
@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 11, 2023
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 11, 2023
@AasheeshLikePanner

AasheeshLikePanner commented Oct 11, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@cclauss Can you check now.

cclauss
cclauss requested changes Oct 11, 2023
View reviewed changes
Comment threadmaths/simpson_rule.py Outdated
@algorithms-keeperalgorithms-keeperBot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 11, 2023
@AasheeshLikePanner
Merge remote-tracking branch 'origin/simpson_rule_doctests' into simp…
39fa849
…son_rule_doctests
# Conflicts:
#	maths/simpson_rule.py
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 11, 2023
@AasheeshLikePanner

AasheeshLikePanner commented Oct 11, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss Can you check now.

cclauss
cclauss reviewed Oct 11, 2023
View reviewed changes
Comment threadmaths/simpson_rule.py Outdated
@cclauss
cclauss enabled auto-merge (squash) October 11, 2023 17:58
auto-merge was automatically disabled October 11, 2023 18:00

Head branch was pushed to by a user without write access

@algorithms-keeperalgorithms-keeperBot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 11, 2023
@cclauss
cclauss enabled auto-merge (squash) October 11, 2023 18:19
@cclauss
cclauss disabled auto-merge October 11, 2023 18:19
cclauss
cclauss approved these changes Oct 11, 2023
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023
@cclauss
cclauss merged commit d5323db into TheAlgorithms:masterOct 11, 2023
@AasheeshLikePanner

AasheeshLikePanner commented Oct 11, 2023

Copy link
Copy Markdown
ContributorAuthor

Thank you for helping me to understand how to handle errors in doctests. A great learning today.
Thank you.

@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

enhancementThis PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AasheeshLikePanner@cclauss