Count pairs with given sum by siddwarr · Pull Request #10282 · TheAlgorithms/Python

siddwarr · 2023-10-11T17:09:04Z

Describe your change:

I have added the solution to the problem for counting the no of pairs in an array with the given sum in the most optimal way

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

…arr/Python_hacktoberfest into count_pairs_with_given_sum

for more information, see https://pre-commit.ci

cclauss · 2023-10-11T20:47:11Z

I am lost. What is the value of solving this? In what situation would this algorithm be useful?

The first half of the algorithm could be a one-liner by using a defaultdict or a Counter.

CaedenPH · 2023-10-11T21:15:07Z

+ >>> pairs_with_sum([1,7,6,2,5,4,3,1,9,8],7)
+ 4
+ """
+ d: dict = {}


Suggested change
d: dict= {}
d= {}
This type is inferred. Also try to use more descriptive variable names

So I had to add that because it wasn't passing all the three tasks. I know we don't have to mention the type but I did so just to pass all the three tasks

It gave some type not specified error

CaedenPH · 2023-10-11T21:16:59Z

+ d[i] -= 1
+ if req_sum - i in d and d[req_sum - i] != 0:
+ ans += d[req_sum - i]
+ d[i] += 1


You are subtracting one, and then adding one after an irrelevant if statement. Why?

So the reason I included that is because let's say the given number is 8 and you have 4 in your array. Now if u don't decrement d[4] by 1 then from the code it will check if 4 exists in the dictionary and as it does ans will be incremented. So even though there is only one 4 in the array it will still be considered. I could remove that and put if d[req-i]!=1

siddwarr · 2023-10-12T02:34:37Z

I am lost. What is the value of solving this? In what situation would this algorithm be useful?
The first half of the algorithm could be a one-liner by using a defaultdict or a Counter.

This is the solution to an array leetcode problem. Yes you can use defaultdict for the first half. I just thought this will be more descriptive and easier to comprehend. I can change that. I think this problem is good for beginners to understand why hashing is required for these types of array questions

cclauss · 2023-10-12T07:48:38Z

This is the solution to an array leetcode problem.

Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.

Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.

If reviewers are confused by it then the code or its documentation must be improved before it can be merged.

for more information, see https://pre-commit.ci

siddwarr · 2023-10-12T08:31:45Z

This is the solution to an array leetcode problem.
Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.
Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.
If reviewers are confused by it then the code or its documentation must be improved before it can be merged.

So when I'm using defaultdict it says it needs type annotation for d. This was the same error I was getting before also thats the reason i didnt use defaultdict before. How do I fix this

siddwarr · 2023-10-12T08:32:17Z

This is the solution to an array leetcode problem.
Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.
Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.
If reviewers are confused by it then the code or its documentation must be improved before it can be merged.
So when I'm using defaultdict it says it needs type annotation for d. This was the same error I was getting before also thats the reason i didnt use defaultdict before. How do I fix this

I have added the problem link in the docstring

for more information, see https://pre-commit.ci

cclauss · 2023-10-12T08:49:46Z

+Count the no of pairs in a given array with given sum
+Problem URL- https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0


Suggested change
Countthenoofpairsinagivenarraywithgivensum
ProblemURL-https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0
Givenanarrayofintegersandanintegerreq_sum, findthenumberofpairsofarray
elementswhosesumisequaltoreq_sum.
https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0

siddwarr · 2023-10-11T17:09:04Z

Describe your change:

I have added the solution to the problem for counting the no of pairs in an array with the given sum in the most optimal way

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

…arr/Python_hacktoberfest into count_pairs_with_given_sum

for more information, see https://pre-commit.ci

cclauss · 2023-10-11T20:47:11Z

I am lost. What is the value of solving this? In what situation would this algorithm be useful?

The first half of the algorithm could be a one-liner by using a defaultdict or a Counter.

CaedenPH · 2023-10-11T21:15:07Z

+ >>> pairs_with_sum([1,7,6,2,5,4,3,1,9,8],7)
+ 4
+ """
+ d: dict = {}


Suggested change
d: dict= {}
d= {}
This type is inferred. Also try to use more descriptive variable names

So I had to add that because it wasn't passing all the three tasks. I know we don't have to mention the type but I did so just to pass all the three tasks

It gave some type not specified error

CaedenPH · 2023-10-11T21:16:59Z

+ d[i] -= 1
+ if req_sum - i in d and d[req_sum - i] != 0:
+ ans += d[req_sum - i]
+ d[i] += 1


You are subtracting one, and then adding one after an irrelevant if statement. Why?

So the reason I included that is because let's say the given number is 8 and you have 4 in your array. Now if u don't decrement d[4] by 1 then from the code it will check if 4 exists in the dictionary and as it does ans will be incremented. So even though there is only one 4 in the array it will still be considered. I could remove that and put if d[req-i]!=1

siddwarr · 2023-10-12T02:34:37Z

I am lost. What is the value of solving this? In what situation would this algorithm be useful?
The first half of the algorithm could be a one-liner by using a defaultdict or a Counter.

This is the solution to an array leetcode problem. Yes you can use defaultdict for the first half. I just thought this will be more descriptive and easier to comprehend. I can change that. I think this problem is good for beginners to understand why hashing is required for these types of array questions

cclauss · 2023-10-12T07:48:38Z

This is the solution to an array leetcode problem.

Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.

Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.

If reviewers are confused by it then the code or its documentation must be improved before it can be merged.

for more information, see https://pre-commit.ci

siddwarr · 2023-10-12T08:31:45Z

This is the solution to an array leetcode problem.
Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.
Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.
If reviewers are confused by it then the code or its documentation must be improved before it can be merged.

So when I'm using defaultdict it says it needs type annotation for d. This was the same error I was getting before also thats the reason i didnt use defaultdict before. How do I fix this

siddwarr · 2023-10-12T08:32:17Z

This is the solution to an array leetcode problem.
Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.
Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.
If reviewers are confused by it then the code or its documentation must be improved before it can be merged.
So when I'm using defaultdict it says it needs type annotation for d. This was the same error I was getting before also thats the reason i didnt use defaultdict before. How do I fix this

I have added the problem link in the docstring

for more information, see https://pre-commit.ci

cclauss · 2023-10-12T08:49:46Z

+Count the no of pairs in a given array with given sum
+Problem URL- https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0


Suggested change
Countthenoofpairsinagivenarraywithgivensum
ProblemURL-https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0
Givenanarrayofintegersandanintegerreq_sum, findthenumberofpairsofarray
elementswhosesumisequaltoreq_sum.
https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0

siddwarr · 2023-10-11T17:09:04Z

Describe your change:

I have added the solution to the problem for counting the no of pairs in an array with the given sum in the most optimal way

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

…arr/Python_hacktoberfest into count_pairs_with_given_sum

for more information, see https://pre-commit.ci

cclauss · 2023-10-11T20:47:11Z

I am lost. What is the value of solving this? In what situation would this algorithm be useful?

The first half of the algorithm could be a one-liner by using a defaultdict or a Counter.

CaedenPH · 2023-10-11T21:15:07Z

+ >>> pairs_with_sum([1,7,6,2,5,4,3,1,9,8],7)
+ 4
+ """
+ d: dict = {}


Suggested change
d: dict= {}
d= {}
This type is inferred. Also try to use more descriptive variable names

So I had to add that because it wasn't passing all the three tasks. I know we don't have to mention the type but I did so just to pass all the three tasks

It gave some type not specified error

CaedenPH · 2023-10-11T21:16:59Z

+ d[i] -= 1
+ if req_sum - i in d and d[req_sum - i] != 0:
+ ans += d[req_sum - i]
+ d[i] += 1


You are subtracting one, and then adding one after an irrelevant if statement. Why?

So the reason I included that is because let's say the given number is 8 and you have 4 in your array. Now if u don't decrement d[4] by 1 then from the code it will check if 4 exists in the dictionary and as it does ans will be incremented. So even though there is only one 4 in the array it will still be considered. I could remove that and put if d[req-i]!=1

siddwarr · 2023-10-12T02:34:37Z

I am lost. What is the value of solving this? In what situation would this algorithm be useful?
The first half of the algorithm could be a one-liner by using a defaultdict or a Counter.

This is the solution to an array leetcode problem. Yes you can use defaultdict for the first half. I just thought this will be more descriptive and easier to comprehend. I can change that. I think this problem is good for beginners to understand why hashing is required for these types of array questions

cclauss · 2023-10-12T07:48:38Z

This is the solution to an array leetcode problem.

Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.

Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.

If reviewers are confused by it then the code or its documentation must be improved before it can be merged.

for more information, see https://pre-commit.ci

siddwarr · 2023-10-12T08:31:45Z

This is the solution to an array leetcode problem.
Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.
Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.
If reviewers are confused by it then the code or its documentation must be improved before it can be merged.

So when I'm using defaultdict it says it needs type annotation for d. This was the same error I was getting before also thats the reason i didnt use defaultdict before. How do I fix this

siddwarr · 2023-10-12T08:32:17Z

This is the solution to an array leetcode problem.
Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.
Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.
If reviewers are confused by it then the code or its documentation must be improved before it can be merged.
So when I'm using defaultdict it says it needs type annotation for d. This was the same error I was getting before also thats the reason i didnt use defaultdict before. How do I fix this

I have added the problem link in the docstring

for more information, see https://pre-commit.ci

cclauss · 2023-10-12T08:49:46Z

+Count the no of pairs in a given array with given sum
+Problem URL- https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0


Suggested change
Countthenoofpairsinagivenarraywithgivensum
ProblemURL-https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0
Givenanarrayofintegersandanintegerreq_sum, findthenumberofpairsofarray
elementswhosesumisequaltoreq_sum.
https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0

siddwarr · 2023-10-11T17:09:04Z

Describe your change:

I have added the solution to the problem for counting the no of pairs in an array with the given sum in the most optimal way

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

…arr/Python_hacktoberfest into count_pairs_with_given_sum

for more information, see https://pre-commit.ci

cclauss · 2023-10-11T20:47:11Z

I am lost. What is the value of solving this? In what situation would this algorithm be useful?

The first half of the algorithm could be a one-liner by using a defaultdict or a Counter.

CaedenPH · 2023-10-11T21:15:07Z

+ >>> pairs_with_sum([1,7,6,2,5,4,3,1,9,8],7)
+ 4
+ """
+ d: dict = {}


Suggested change
d: dict= {}
d= {}
This type is inferred. Also try to use more descriptive variable names

So I had to add that because it wasn't passing all the three tasks. I know we don't have to mention the type but I did so just to pass all the three tasks

It gave some type not specified error

CaedenPH · 2023-10-11T21:16:59Z

+ d[i] -= 1
+ if req_sum - i in d and d[req_sum - i] != 0:
+ ans += d[req_sum - i]
+ d[i] += 1


You are subtracting one, and then adding one after an irrelevant if statement. Why?

So the reason I included that is because let's say the given number is 8 and you have 4 in your array. Now if u don't decrement d[4] by 1 then from the code it will check if 4 exists in the dictionary and as it does ans will be incremented. So even though there is only one 4 in the array it will still be considered. I could remove that and put if d[req-i]!=1

siddwarr · 2023-10-12T02:34:37Z

I am lost. What is the value of solving this? In what situation would this algorithm be useful?
The first half of the algorithm could be a one-liner by using a defaultdict or a Counter.

This is the solution to an array leetcode problem. Yes you can use defaultdict for the first half. I just thought this will be more descriptive and easier to comprehend. I can change that. I think this problem is good for beginners to understand why hashing is required for these types of array questions

cclauss · 2023-10-12T07:48:38Z

This is the solution to an array leetcode problem.

Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.

Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.

If reviewers are confused by it then the code or its documentation must be improved before it can be merged.

for more information, see https://pre-commit.ci

siddwarr · 2023-10-12T08:31:45Z

This is the solution to an array leetcode problem.
Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.
Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.
If reviewers are confused by it then the code or its documentation must be improved before it can be merged.

So when I'm using defaultdict it says it needs type annotation for d. This was the same error I was getting before also thats the reason i didnt use defaultdict before. How do I fix this

siddwarr · 2023-10-12T08:32:17Z

This is the solution to an array leetcode problem.
Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.
Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.
If reviewers are confused by it then the code or its documentation must be improved before it can be merged.
So when I'm using defaultdict it says it needs type annotation for d. This was the same error I was getting before also thats the reason i didnt use defaultdict before. How do I fix this

I have added the problem link in the docstring

for more information, see https://pre-commit.ci

cclauss · 2023-10-12T08:49:46Z

+Count the no of pairs in a given array with given sum
+Problem URL- https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0


Suggested change
Countthenoofpairsinagivenarraywithgivensum
ProblemURL-https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0
Givenanarrayofintegersandanintegerreq_sum, findthenumberofpairsofarray
elementswhosesumisequaltoreq_sum.
https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0

siddwarr · 2023-10-11T17:09:04Z

Describe your change:

I have added the solution to the problem for counting the no of pairs in an array with the given sum in the most optimal way

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

…arr/Python_hacktoberfest into count_pairs_with_given_sum

for more information, see https://pre-commit.ci

cclauss · 2023-10-11T20:47:11Z

I am lost. What is the value of solving this? In what situation would this algorithm be useful?

The first half of the algorithm could be a one-liner by using a defaultdict or a Counter.

CaedenPH · 2023-10-11T21:15:07Z

+ >>> pairs_with_sum([1,7,6,2,5,4,3,1,9,8],7)
+ 4
+ """
+ d: dict = {}


Suggested change
d: dict= {}
d= {}
This type is inferred. Also try to use more descriptive variable names

So I had to add that because it wasn't passing all the three tasks. I know we don't have to mention the type but I did so just to pass all the three tasks

It gave some type not specified error

CaedenPH · 2023-10-11T21:16:59Z

+ d[i] -= 1
+ if req_sum - i in d and d[req_sum - i] != 0:
+ ans += d[req_sum - i]
+ d[i] += 1


You are subtracting one, and then adding one after an irrelevant if statement. Why?

So the reason I included that is because let's say the given number is 8 and you have 4 in your array. Now if u don't decrement d[4] by 1 then from the code it will check if 4 exists in the dictionary and as it does ans will be incremented. So even though there is only one 4 in the array it will still be considered. I could remove that and put if d[req-i]!=1

siddwarr · 2023-10-12T02:34:37Z

I am lost. What is the value of solving this? In what situation would this algorithm be useful?
The first half of the algorithm could be a one-liner by using a defaultdict or a Counter.

This is the solution to an array leetcode problem. Yes you can use defaultdict for the first half. I just thought this will be more descriptive and easier to comprehend. I can change that. I think this problem is good for beginners to understand why hashing is required for these types of array questions

cclauss · 2023-10-12T07:48:38Z

This is the solution to an array leetcode problem.

Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.

Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.

If reviewers are confused by it then the code or its documentation must be improved before it can be merged.

for more information, see https://pre-commit.ci

siddwarr · 2023-10-12T08:31:45Z

This is the solution to an array leetcode problem.
Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.
Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.
If reviewers are confused by it then the code or its documentation must be improved before it can be merged.

So when I'm using defaultdict it says it needs type annotation for d. This was the same error I was getting before also thats the reason i didnt use defaultdict before. How do I fix this

siddwarr · 2023-10-12T08:32:17Z

This is the solution to an array leetcode problem.
Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.
Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.
If reviewers are confused by it then the code or its documentation must be improved before it can be merged.
So when I'm using defaultdict it says it needs type annotation for d. This was the same error I was getting before also thats the reason i didnt use defaultdict before. How do I fix this

I have added the problem link in the docstring

for more information, see https://pre-commit.ci

cclauss · 2023-10-12T08:49:46Z

+Count the no of pairs in a given array with given sum
+Problem URL- https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0


Suggested change
Countthenoofpairsinagivenarraywithgivensum
ProblemURL-https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0
Givenanarrayofintegersandanintegerreq_sum, findthenumberofpairsofarray
elementswhosesumisequaltoreq_sum.
https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0

siddwarr · 2023-10-11T17:09:04Z

Describe your change:

I have added the solution to the problem for counting the no of pairs in an array with the given sum in the most optimal way

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

…arr/Python_hacktoberfest into count_pairs_with_given_sum

for more information, see https://pre-commit.ci

cclauss · 2023-10-11T20:47:11Z

I am lost. What is the value of solving this? In what situation would this algorithm be useful?

The first half of the algorithm could be a one-liner by using a defaultdict or a Counter.

CaedenPH · 2023-10-11T21:15:07Z

+ >>> pairs_with_sum([1,7,6,2,5,4,3,1,9,8],7)
+ 4
+ """
+ d: dict = {}


Suggested change
d: dict= {}
d= {}
This type is inferred. Also try to use more descriptive variable names

So I had to add that because it wasn't passing all the three tasks. I know we don't have to mention the type but I did so just to pass all the three tasks

It gave some type not specified error

CaedenPH · 2023-10-11T21:16:59Z

+ d[i] -= 1
+ if req_sum - i in d and d[req_sum - i] != 0:
+ ans += d[req_sum - i]
+ d[i] += 1


You are subtracting one, and then adding one after an irrelevant if statement. Why?

So the reason I included that is because let's say the given number is 8 and you have 4 in your array. Now if u don't decrement d[4] by 1 then from the code it will check if 4 exists in the dictionary and as it does ans will be incremented. So even though there is only one 4 in the array it will still be considered. I could remove that and put if d[req-i]!=1

siddwarr · 2023-10-12T02:34:37Z

I am lost. What is the value of solving this? In what situation would this algorithm be useful?
The first half of the algorithm could be a one-liner by using a defaultdict or a Counter.

This is the solution to an array leetcode problem. Yes you can use defaultdict for the first half. I just thought this will be more descriptive and easier to comprehend. I can change that. I think this problem is good for beginners to understand why hashing is required for these types of array questions

cclauss · 2023-10-12T07:48:38Z

This is the solution to an array leetcode problem.

Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.

Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.

If reviewers are confused by it then the code or its documentation must be improved before it can be merged.

for more information, see https://pre-commit.ci

siddwarr · 2023-10-12T08:31:45Z

This is the solution to an array leetcode problem.
Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.
Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.
If reviewers are confused by it then the code or its documentation must be improved before it can be merged.

So when I'm using defaultdict it says it needs type annotation for d. This was the same error I was getting before also thats the reason i didnt use defaultdict before. How do I fix this

siddwarr · 2023-10-12T08:32:17Z

This is the solution to an array leetcode problem.
Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.
Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.
If reviewers are confused by it then the code or its documentation must be improved before it can be merged.
So when I'm using defaultdict it says it needs type annotation for d. This was the same error I was getting before also thats the reason i didnt use defaultdict before. How do I fix this

I have added the problem link in the docstring

for more information, see https://pre-commit.ci

cclauss · 2023-10-12T08:49:46Z

+Count the no of pairs in a given array with given sum
+Problem URL- https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0


Suggested change
Countthenoofpairsinagivenarraywithgivensum
ProblemURL-https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0
Givenanarrayofintegersandanintegerreq_sum, findthenumberofpairsofarray
elementswhosesumisequaltoreq_sum.
https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0

siddwarr · 2023-10-11T17:09:04Z

Describe your change:

I have added the solution to the problem for counting the no of pairs in an array with the given sum in the most optimal way

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

…arr/Python_hacktoberfest into count_pairs_with_given_sum

for more information, see https://pre-commit.ci

cclauss · 2023-10-11T20:47:11Z

I am lost. What is the value of solving this? In what situation would this algorithm be useful?

The first half of the algorithm could be a one-liner by using a defaultdict or a Counter.

CaedenPH · 2023-10-11T21:15:07Z

+ >>> pairs_with_sum([1,7,6,2,5,4,3,1,9,8],7)
+ 4
+ """
+ d: dict = {}


Suggested change
d: dict= {}
d= {}
This type is inferred. Also try to use more descriptive variable names

So I had to add that because it wasn't passing all the three tasks. I know we don't have to mention the type but I did so just to pass all the three tasks

It gave some type not specified error

CaedenPH · 2023-10-11T21:16:59Z

+ d[i] -= 1
+ if req_sum - i in d and d[req_sum - i] != 0:
+ ans += d[req_sum - i]
+ d[i] += 1


You are subtracting one, and then adding one after an irrelevant if statement. Why?

So the reason I included that is because let's say the given number is 8 and you have 4 in your array. Now if u don't decrement d[4] by 1 then from the code it will check if 4 exists in the dictionary and as it does ans will be incremented. So even though there is only one 4 in the array it will still be considered. I could remove that and put if d[req-i]!=1

siddwarr · 2023-10-12T02:34:37Z

I am lost. What is the value of solving this? In what situation would this algorithm be useful?
The first half of the algorithm could be a one-liner by using a defaultdict or a Counter.

This is the solution to an array leetcode problem. Yes you can use defaultdict for the first half. I just thought this will be more descriptive and easier to comprehend. I can change that. I think this problem is good for beginners to understand why hashing is required for these types of array questions

cclauss · 2023-10-12T07:48:38Z

This is the solution to an array leetcode problem.

Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.

Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.

If reviewers are confused by it then the code or its documentation must be improved before it can be merged.

for more information, see https://pre-commit.ci

siddwarr · 2023-10-12T08:31:45Z

This is the solution to an array leetcode problem.
Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.
Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.
If reviewers are confused by it then the code or its documentation must be improved before it can be merged.

So when I'm using defaultdict it says it needs type annotation for d. This was the same error I was getting before also thats the reason i didnt use defaultdict before. How do I fix this

siddwarr · 2023-10-12T08:32:17Z

This is the solution to an array leetcode problem.
Please add a URL to the problem in the docstring at the top of the file as recommended in CONTRIBUTING.md.
Please use a defaultdict or Counter as this repo is for visitors who want to study quality algorithms.
If reviewers are confused by it then the code or its documentation must be improved before it can be merged.
So when I'm using defaultdict it says it needs type annotation for d. This was the same error I was getting before also thats the reason i didnt use defaultdict before. How do I fix this

I have added the problem link in the docstring

for more information, see https://pre-commit.ci

cclauss · 2023-10-12T08:49:46Z

+Count the no of pairs in a given array with given sum
+Problem URL- https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0


Suggested change
Countthenoofpairsinagivenarraywithgivensum
ProblemURL-https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0
Givenanarrayofintegersandanintegerreq_sum, findthenumberofpairsofarray
elementswhosesumisequaltoreq_sum.
https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0

siddwarrand others added 16 commits October 2, 2023 21:28

added power_of_4
c08e138

deleted power_of_4
60e1a83

Merge branch 'TheAlgorithms:master' into master
1720083

Merge branch 'TheAlgorithms:master' into master
595ad2d

added pairs_with_given_sum
2290ff9

[pre-commit.ci] auto fixes from pre-commit.com hooks
1f94b83
for more information, see https://pre-commit.ci

updated the comment
4251cf5

Merge branch 'count_pairs_with_given_sum' ofhttps://github.com/siddw…
a8cb552
…arr/Python_hacktoberfest into count_pairs_with_given_sum

updated return hint
a3ee9eb

updated type hints
f6f790f

updated the variable
6a0daf4

updated annotation
77b6a7c

updated code
8bf754d

updated code
42d2c13

[pre-commit.ci] auto fixes from pre-commit.com hooks
f39e168
for more information, see https://pre-commit.ci

Merge branch 'TheAlgorithms:master' into count_pairs_with_given_sum
9ea6c3e

algorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023

CaedenPH reviewed Oct 11, 2023
View reviewed changes

siddwarrand others added 3 commits October 12, 2023 13:56

added the problem link and used defaultdict
fdfe4f4

Merge branch 'TheAlgorithms:master' into count_pairs_with_given_sum
a42c88b

[pre-commit.ci] auto fixes from pre-commit.com hooks
0752ae1
for more information, see https://pre-commit.ci

algorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 12, 2023

siddwarrand others added 2 commits October 12, 2023 14:04

corrected import formatting
d40eaa1

[pre-commit.ci] auto fixes from pre-commit.com hooks
ce68b14
for more information, see https://pre-commit.ci

cclauss reviewed Oct 12, 2023
View reviewed changes

Update pairs_with_given_sum.py
27dc6d2

algorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 12, 2023

cclauss reviewed Oct 12, 2023
View reviewed changes

Comment threaddata_structures/arrays/pairs_with_given_sum.py Outdated

Update data_structures/arrays/pairs_with_given_sum.py
e4befa3

cclauss enabled auto-merge (squash) October 12, 2023 09:08

cclauss disabled auto-merge October 12, 2023 09:08

cclauss enabled auto-merge (squash) October 12, 2023 09:08

cclauss approved these changes Oct 12, 2023
View reviewed changes

cclauss merged commit 09ce6b2 into TheAlgorithms:masterOct 12, 2023

algorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 12, 2023

siddwarr deleted the count_pairs_with_given_sum branch October 12, 2023 10:12

isidroas mentioned this pull request Jan 25, 2025
dh isidroas/Python#1
Closed
14 tasks

siddwarrand others added 16 commits October 2, 2023 21:28

added power_of_4
c08e138

deleted power_of_4
60e1a83

Merge branch 'TheAlgorithms:master' into master
1720083

Merge branch 'TheAlgorithms:master' into master
595ad2d

added pairs_with_given_sum
2290ff9

[pre-commit.ci] auto fixes from pre-commit.com hooks
1f94b83
for more information, see https://pre-commit.ci

updated the comment
4251cf5

Merge branch 'count_pairs_with_given_sum' ofhttps://github.com/siddw…
a8cb552
…arr/Python_hacktoberfest into count_pairs_with_given_sum

updated return hint
a3ee9eb

updated type hints
f6f790f

updated the variable
6a0daf4

updated annotation
77b6a7c

updated code
8bf754d

updated code
42d2c13

[pre-commit.ci] auto fixes from pre-commit.com hooks
f39e168
for more information, see https://pre-commit.ci

Merge branch 'TheAlgorithms:master' into count_pairs_with_given_sum
9ea6c3e

algorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023

CaedenPH reviewed Oct 11, 2023
View reviewed changes

siddwarrand others added 3 commits October 12, 2023 13:56

added the problem link and used defaultdict
fdfe4f4

Merge branch 'TheAlgorithms:master' into count_pairs_with_given_sum
a42c88b

[pre-commit.ci] auto fixes from pre-commit.com hooks
0752ae1
for more information, see https://pre-commit.ci

algorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 12, 2023

siddwarrand others added 2 commits October 12, 2023 14:04

corrected import formatting
d40eaa1

[pre-commit.ci] auto fixes from pre-commit.com hooks
ce68b14
for more information, see https://pre-commit.ci

cclauss reviewed Oct 12, 2023
View reviewed changes

Update pairs_with_given_sum.py
27dc6d2

algorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 12, 2023

cclauss reviewed Oct 12, 2023
View reviewed changes

Comment threaddata_structures/arrays/pairs_with_given_sum.py Outdated

Update data_structures/arrays/pairs_with_given_sum.py
e4befa3

cclauss enabled auto-merge (squash) October 12, 2023 09:08

cclauss disabled auto-merge October 12, 2023 09:08

cclauss enabled auto-merge (squash) October 12, 2023 09:08

cclauss approved these changes Oct 12, 2023
View reviewed changes

cclauss merged commit 09ce6b2 into TheAlgorithms:masterOct 12, 2023

algorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 12, 2023

siddwarr deleted the count_pairs_with_given_sum branch October 12, 2023 10:12

isidroas mentioned this pull request Jan 25, 2025
dh isidroas/Python#1
Closed
14 tasks

siddwarrand others added 16 commits October 2, 2023 21:28

added power_of_4
c08e138

deleted power_of_4
60e1a83

Merge branch 'TheAlgorithms:master' into master
1720083

Merge branch 'TheAlgorithms:master' into master
595ad2d

added pairs_with_given_sum
2290ff9

[pre-commit.ci] auto fixes from pre-commit.com hooks
1f94b83
for more information, see https://pre-commit.ci

updated the comment
4251cf5

Merge branch 'count_pairs_with_given_sum' ofhttps://github.com/siddw…
a8cb552
…arr/Python_hacktoberfest into count_pairs_with_given_sum

updated return hint
a3ee9eb

updated type hints
f6f790f

updated the variable
6a0daf4

updated annotation
77b6a7c

updated code
8bf754d

updated code
42d2c13

[pre-commit.ci] auto fixes from pre-commit.com hooks
f39e168
for more information, see https://pre-commit.ci

Merge branch 'TheAlgorithms:master' into count_pairs_with_given_sum
9ea6c3e

algorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023

CaedenPH reviewed Oct 11, 2023
View reviewed changes

siddwarrand others added 3 commits October 12, 2023 13:56

added the problem link and used defaultdict
fdfe4f4

Merge branch 'TheAlgorithms:master' into count_pairs_with_given_sum
a42c88b

[pre-commit.ci] auto fixes from pre-commit.com hooks
0752ae1
for more information, see https://pre-commit.ci

algorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 12, 2023

siddwarrand others added 2 commits October 12, 2023 14:04

corrected import formatting
d40eaa1

[pre-commit.ci] auto fixes from pre-commit.com hooks
ce68b14
for more information, see https://pre-commit.ci

cclauss reviewed Oct 12, 2023
View reviewed changes

Update pairs_with_given_sum.py
27dc6d2

algorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 12, 2023

cclauss reviewed Oct 12, 2023
View reviewed changes

Comment threaddata_structures/arrays/pairs_with_given_sum.py Outdated

Update data_structures/arrays/pairs_with_given_sum.py
e4befa3

cclauss enabled auto-merge (squash) October 12, 2023 09:08

cclauss disabled auto-merge October 12, 2023 09:08

cclauss enabled auto-merge (squash) October 12, 2023 09:08

cclauss approved these changes Oct 12, 2023
View reviewed changes

cclauss merged commit 09ce6b2 into TheAlgorithms:masterOct 12, 2023

algorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 12, 2023

siddwarr deleted the count_pairs_with_given_sum branch October 12, 2023 10:12

isidroas mentioned this pull request Jan 25, 2025
dh isidroas/Python#1
Closed
14 tasks

siddwarrand others added 16 commits October 2, 2023 21:28

added power_of_4
c08e138

deleted power_of_4
60e1a83

Merge branch 'TheAlgorithms:master' into master
1720083

Merge branch 'TheAlgorithms:master' into master
595ad2d

added pairs_with_given_sum
2290ff9

[pre-commit.ci] auto fixes from pre-commit.com hooks
1f94b83
for more information, see https://pre-commit.ci

updated the comment
4251cf5

Merge branch 'count_pairs_with_given_sum' ofhttps://github.com/siddw…
a8cb552
…arr/Python_hacktoberfest into count_pairs_with_given_sum

updated return hint
a3ee9eb

updated type hints
f6f790f

updated the variable
6a0daf4

updated annotation
77b6a7c

updated code
8bf754d

updated code
42d2c13

[pre-commit.ci] auto fixes from pre-commit.com hooks
f39e168
for more information, see https://pre-commit.ci

Merge branch 'TheAlgorithms:master' into count_pairs_with_given_sum
9ea6c3e

algorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023

CaedenPH reviewed Oct 11, 2023
View reviewed changes

siddwarrand others added 3 commits October 12, 2023 13:56

added the problem link and used defaultdict
fdfe4f4

Merge branch 'TheAlgorithms:master' into count_pairs_with_given_sum
a42c88b

[pre-commit.ci] auto fixes from pre-commit.com hooks
0752ae1
for more information, see https://pre-commit.ci

algorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 12, 2023

siddwarrand others added 2 commits October 12, 2023 14:04

corrected import formatting
d40eaa1

[pre-commit.ci] auto fixes from pre-commit.com hooks
ce68b14
for more information, see https://pre-commit.ci

cclauss reviewed Oct 12, 2023
View reviewed changes

Update pairs_with_given_sum.py
27dc6d2

algorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 12, 2023

cclauss reviewed Oct 12, 2023
View reviewed changes

Comment threaddata_structures/arrays/pairs_with_given_sum.py Outdated

Update data_structures/arrays/pairs_with_given_sum.py
e4befa3

cclauss enabled auto-merge (squash) October 12, 2023 09:08

cclauss disabled auto-merge October 12, 2023 09:08

cclauss enabled auto-merge (squash) October 12, 2023 09:08

cclauss approved these changes Oct 12, 2023
View reviewed changes

cclauss merged commit 09ce6b2 into TheAlgorithms:masterOct 12, 2023

algorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 12, 2023

siddwarr deleted the count_pairs_with_given_sum branch October 12, 2023 10:12

isidroas mentioned this pull request Jan 25, 2025
dh isidroas/Python#1
Closed
14 tasks

siddwarrand others added 16 commits October 2, 2023 21:28

added power_of_4
c08e138

deleted power_of_4
60e1a83

Merge branch 'TheAlgorithms:master' into master
1720083

Merge branch 'TheAlgorithms:master' into master
595ad2d

added pairs_with_given_sum
2290ff9

[pre-commit.ci] auto fixes from pre-commit.com hooks
1f94b83
for more information, see https://pre-commit.ci

updated the comment
4251cf5

Merge branch 'count_pairs_with_given_sum' ofhttps://github.com/siddw…
a8cb552
…arr/Python_hacktoberfest into count_pairs_with_given_sum

updated return hint
a3ee9eb

updated type hints
f6f790f

updated the variable
6a0daf4

updated annotation
77b6a7c

updated code
8bf754d

updated code
42d2c13

[pre-commit.ci] auto fixes from pre-commit.com hooks
f39e168
for more information, see https://pre-commit.ci

Merge branch 'TheAlgorithms:master' into count_pairs_with_given_sum
9ea6c3e

algorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023

CaedenPH reviewed Oct 11, 2023
View reviewed changes

siddwarrand others added 3 commits October 12, 2023 13:56

added the problem link and used defaultdict
fdfe4f4

Merge branch 'TheAlgorithms:master' into count_pairs_with_given_sum
a42c88b

[pre-commit.ci] auto fixes from pre-commit.com hooks
0752ae1
for more information, see https://pre-commit.ci

algorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 12, 2023

siddwarrand others added 2 commits October 12, 2023 14:04

corrected import formatting
d40eaa1

[pre-commit.ci] auto fixes from pre-commit.com hooks
ce68b14
for more information, see https://pre-commit.ci

cclauss reviewed Oct 12, 2023
View reviewed changes

Update pairs_with_given_sum.py
27dc6d2

algorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 12, 2023

cclauss reviewed Oct 12, 2023
View reviewed changes

Comment threaddata_structures/arrays/pairs_with_given_sum.py Outdated

Update data_structures/arrays/pairs_with_given_sum.py
e4befa3

cclauss enabled auto-merge (squash) October 12, 2023 09:08

cclauss disabled auto-merge October 12, 2023 09:08

cclauss enabled auto-merge (squash) October 12, 2023 09:08

cclauss approved these changes Oct 12, 2023
View reviewed changes

cclauss merged commit 09ce6b2 into TheAlgorithms:masterOct 12, 2023

algorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 12, 2023

siddwarr deleted the count_pairs_with_given_sum branch October 12, 2023 10:12

isidroas mentioned this pull request Jan 25, 2025
dh isidroas/Python#1
Closed
14 tasks

siddwarrand others added 16 commits October 2, 2023 21:28

added power_of_4
c08e138

deleted power_of_4
60e1a83

Merge branch 'TheAlgorithms:master' into master
1720083

Merge branch 'TheAlgorithms:master' into master
595ad2d

added pairs_with_given_sum
2290ff9

[pre-commit.ci] auto fixes from pre-commit.com hooks
1f94b83
for more information, see https://pre-commit.ci

updated the comment
4251cf5

Merge branch 'count_pairs_with_given_sum' ofhttps://github.com/siddw…
a8cb552
…arr/Python_hacktoberfest into count_pairs_with_given_sum

updated return hint
a3ee9eb

updated type hints
f6f790f

updated the variable
6a0daf4

updated annotation
77b6a7c

updated code
8bf754d

updated code
42d2c13

[pre-commit.ci] auto fixes from pre-commit.com hooks
f39e168
for more information, see https://pre-commit.ci

Merge branch 'TheAlgorithms:master' into count_pairs_with_given_sum
9ea6c3e

algorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023

CaedenPH reviewed Oct 11, 2023
View reviewed changes

siddwarrand others added 3 commits October 12, 2023 13:56

added the problem link and used defaultdict
fdfe4f4

Merge branch 'TheAlgorithms:master' into count_pairs_with_given_sum
a42c88b

[pre-commit.ci] auto fixes from pre-commit.com hooks
0752ae1
for more information, see https://pre-commit.ci

algorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 12, 2023

siddwarrand others added 2 commits October 12, 2023 14:04

corrected import formatting
d40eaa1

[pre-commit.ci] auto fixes from pre-commit.com hooks
ce68b14
for more information, see https://pre-commit.ci

cclauss reviewed Oct 12, 2023
View reviewed changes

Update pairs_with_given_sum.py
27dc6d2

algorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 12, 2023

cclauss reviewed Oct 12, 2023
View reviewed changes

Comment threaddata_structures/arrays/pairs_with_given_sum.py Outdated

Update data_structures/arrays/pairs_with_given_sum.py
e4befa3

cclauss enabled auto-merge (squash) October 12, 2023 09:08

cclauss disabled auto-merge October 12, 2023 09:08

cclauss enabled auto-merge (squash) October 12, 2023 09:08

cclauss approved these changes Oct 12, 2023
View reviewed changes

cclauss merged commit 09ce6b2 into TheAlgorithms:masterOct 12, 2023

algorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 12, 2023

siddwarr deleted the count_pairs_with_given_sum branch October 12, 2023 10:12

isidroas mentioned this pull request Jan 25, 2025
dh isidroas/Python#1
Closed
14 tasks

siddwarrand others added 16 commits October 2, 2023 21:28

added power_of_4
c08e138

deleted power_of_4
60e1a83

Merge branch 'TheAlgorithms:master' into master
1720083

Merge branch 'TheAlgorithms:master' into master
595ad2d

added pairs_with_given_sum
2290ff9

[pre-commit.ci] auto fixes from pre-commit.com hooks
1f94b83
for more information, see https://pre-commit.ci

updated the comment
4251cf5

Merge branch 'count_pairs_with_given_sum' ofhttps://github.com/siddw…
a8cb552
…arr/Python_hacktoberfest into count_pairs_with_given_sum

updated return hint
a3ee9eb

updated type hints
f6f790f

updated the variable
6a0daf4

updated annotation
77b6a7c

updated code
8bf754d

updated code
42d2c13

[pre-commit.ci] auto fixes from pre-commit.com hooks
f39e168
for more information, see https://pre-commit.ci

Merge branch 'TheAlgorithms:master' into count_pairs_with_given_sum
9ea6c3e

algorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023

CaedenPH reviewed Oct 11, 2023
View reviewed changes

siddwarrand others added 3 commits October 12, 2023 13:56

added the problem link and used defaultdict
fdfe4f4

Merge branch 'TheAlgorithms:master' into count_pairs_with_given_sum
a42c88b

[pre-commit.ci] auto fixes from pre-commit.com hooks
0752ae1
for more information, see https://pre-commit.ci

algorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 12, 2023

siddwarrand others added 2 commits October 12, 2023 14:04

corrected import formatting
d40eaa1

[pre-commit.ci] auto fixes from pre-commit.com hooks
ce68b14
for more information, see https://pre-commit.ci

cclauss reviewed Oct 12, 2023
View reviewed changes

Update pairs_with_given_sum.py
27dc6d2

algorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 12, 2023

cclauss reviewed Oct 12, 2023
View reviewed changes

Comment threaddata_structures/arrays/pairs_with_given_sum.py Outdated

Update data_structures/arrays/pairs_with_given_sum.py
e4befa3

cclauss enabled auto-merge (squash) October 12, 2023 09:08

cclauss disabled auto-merge October 12, 2023 09:08

cclauss enabled auto-merge (squash) October 12, 2023 09:08

cclauss approved these changes Oct 12, 2023
View reviewed changes

cclauss merged commit 09ce6b2 into TheAlgorithms:masterOct 12, 2023

algorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 12, 2023

siddwarr deleted the count_pairs_with_given_sum branch October 12, 2023 10:12

isidroas mentioned this pull request Jan 25, 2025
dh isidroas/Python#1
Closed
14 tasks

		Count the no of pairs in a given array with given sum
		Problem URL- https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0

-Countthenoofpairsinagivenarraywithgivensum
-ProblemURL-https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0
+Givenanarrayofintegersandanintegerreq_sum, findthenumberofpairsofarray
+elementswhosesumisequaltoreq_sum.
+https://practice.geeksforgeeks.org/problems/count-pairs-with-given-sum5022/0

Uh oh!

Uh oh!

Conversation

siddwarr commented Oct 11, 2023

Describe your change:

Checklist:

Uh oh!

cclauss commented Oct 11, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

siddwarr commented Oct 12, 2023

Uh oh!

cclauss commented Oct 12, 2023

Uh oh!

siddwarr commented Oct 12, 2023

Uh oh!

siddwarr commented Oct 12, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

siddwarr commented Oct 11, 2023

Describe your change:

Checklist:

Uh oh!

cclauss commented Oct 11, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

siddwarr commented Oct 12, 2023

Uh oh!

cclauss commented Oct 12, 2023

Uh oh!

siddwarr commented Oct 12, 2023

Uh oh!

siddwarr commented Oct 12, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

siddwarr commented Oct 11, 2023