') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); added rkf45 method by iamrknain · Pull Request #10438 · TheAlgorithms/Python · GitHub
Skip to content

added rkf45 method - #10438

Merged
cclauss merged 19 commits into
TheAlgorithms:masterfrom
iamrknain:algo_maths
Oct 15, 2023
Merged

added rkf45 method#10438
cclauss merged 19 commits into
TheAlgorithms:masterfrom
iamrknain:algo_maths

Conversation

@iamrknain

@iamrknainiamrknain commented Oct 14, 2023

Copy link
Copy Markdown
Contributor

Add an algorithm (rkf45) to TheAlgorithms / Python/maths

@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 14, 2023
@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 14, 2023
iamrknain
iamrknain commented Oct 14, 2023
View reviewed changes

@iamrknainiamrknain left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed whitespace

@iamrknain

iamrknain commented Oct 14, 2023

Copy link
Copy Markdown
ContributorAuthor

removed some whitespace

cclauss
cclauss reviewed Oct 14, 2023
View reviewed changes
Comment threadmaths/rkf45.py Outdated
cclauss
cclauss reviewed Oct 14, 2023
View reviewed changes
Comment threadmaths/rkf45.py Outdated
iamrknain
iamrknain commented Oct 14, 2023
View reviewed changes

@iamrknainiamrknain left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated rkf45.py as per suggestions

@iamrknain

iamrknain commented Oct 14, 2023

Copy link
Copy Markdown
ContributorAuthor

updated rkf45.py as per suggestions

cclauss
cclauss requested changes Oct 14, 2023
View reviewed changes
Comment threadmaths/rkf45.py Outdated
Comment threadmaths/rkf45.py Outdated
#excact value of y[1] is tan(0.2) = 0.2027100355086
>>> def f(x,y):
... return 1+y**2
>>> y=rkf45(f,0,0,0.2,1)

@cclausscclaussOct 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>>>y=rkf45(f,0,0,0.2,1)
>>>y=rkf45(f,0, 0, 0.2,1)

Comment threadmaths/rkf45.py Outdated
@algorithms-keeperalgorithms-keeperBot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 14, 2023
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 15, 2023
iamrknain
iamrknain commented Oct 15, 2023
View reviewed changes

@iamrknainiamrknain left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved Code Quality

@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 15, 2023
cclauss
cclauss reviewed Oct 15, 2023
View reviewed changes
Comment threadmaths/rkf45.py
cclauss
cclauss reviewed Oct 15, 2023
View reviewed changes
Comment threadmaths/rkf45.py Outdated
Comment on lines +35 to +37
>>> y=runge_futta_fehlberg_45(f, 0, 0, 0.2, 1)
>>> y[1]
0.2027100937470787

@cclausscclaussOct 15, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need more than one test. What happens if x_initial is set to 5, -5, 5.5?

What happens if step_size is zero or negative?

What happens if x_final is zero or negative?

What happens if ode is 5 instead of being a function?

Let's have a test that raises a RangeError.

@iamrknainiamrknainOct 15, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Condition on x_initial and x_final is that x_final should be greater than x_initial. They can be zero , negative or positive.
  2. Added exception for step_size as it should be positive.
  3. ode can be a constant function or a function of x and/or y.

@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 15, 2023
iamrknain
iamrknain commented Oct 15, 2023
View reviewed changes

@iamrknainiamrknain left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more test cases and exception.

Comment threadmaths/rkf45.py
Comment threadmaths/rkf45.py Outdated
Comment on lines +35 to +37
>>> y=runge_futta_fehlberg_45(f, 0, 0, 0.2, 1)
>>> y[1]
0.2027100937470787

@iamrknainiamrknainOct 15, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Condition on x_initial and x_final is that x_final should be greater than x_initial. They can be zero , negative or positive.
  2. Added exception for step_size as it should be positive.
  3. ode can be a constant function or a function of x and/or y.

@iamrknain

iamrknain commented Oct 15, 2023

Copy link
Copy Markdown
ContributorAuthor

Added more test cases and exception.

@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 15, 2023
@cclauss
cclauss enabled auto-merge (squash) October 15, 2023 09:06
@cclauss
cclauss merged commit 7dbc301 into TheAlgorithms:masterOct 15, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 15, 2023
@cclauss

cclauss commented Oct 15, 2023

Copy link
Copy Markdown
Member

Nice one! It is great that you deal with invalid input.

@iamrknain

iamrknain commented Oct 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss : Please add hacktoberfest-accepted label so that it can be accepted in hacktoberfest.

@cclausscclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 15, 2023
@iamrknain
iamrknain deleted the algo_maths branch October 15, 2023 11:20
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

hacktoberfest-acceptedAccepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iamrknain@cclauss