Uh oh!
There was an error while loading. Please reload this page.
Dp subset tests Closes #9943 - #10471
Conversation
aryandgandhi
commented
Oct 14, 2023
@cclauss@tianyizheng02 having trouble adding type annotations, there is an issue with ruff and mypy expectecing different annotations |
aryandgandhi
commented
Oct 14, 2023
Added docstring tests, add hacktoberfest tag when possible |
aryandgandhi
commented
Oct 14, 2023
CC. @dhruvmanila |
| for j in range(r): | ||
| print(data[j], end=" ") | ||
| print(" ") | ||
| print(" ".join(map(str, data[:r]))) |
There was a problem hiding this comment.
CONTRIBUTING.md says that algorithmic functions should not print() instead they should return values or yield values or raise exceptions.
aryandgandhi
commented
Oct 14, 2023
updated the print @cclauss |
cclauss
commented
Oct 14, 2023
algorithmic functions should not print() |
aryandgandhi
commented
Oct 14, 2023
Even in the main? |
cclauss
commented
Oct 15, 2023
|
aryandgandhi
commented
Oct 15, 2023
Yeah I removed the print from algorithmic function |
aryandgandhi
commented
Oct 16, 2023
@cclauss can this be merged with Hacktoberfest commit, or any changes you still reocmmend |
cclauss
commented
Oct 17, 2023
This branch has conflicts that must be resolvedSee below. |
cclauss
commented
Oct 17, 2023
Closing in favor of: |


Describe your change:
Checklist: