Skip to content

[ADD] : maths joint probabilty distribution - #10508

Merged
cclauss merged 43 commits into
TheAlgorithms:masterfrom
leonado10000:master
Oct 15, 2023
Merged

[ADD] : maths joint probabilty distribution #10508
cclauss merged 43 commits into
TheAlgorithms:masterfrom
leonado10000:master

Conversation

@leonado10000

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 15, 2023

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 15, 2023
@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 15, 2023

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated


# Function to calculate the expectation (mean)
def expectation(values, probabilities) -> float:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/joint_probability_distribution.py, please provide doctest for the function expectation

Please provide type hint for the parameter: values

Please provide type hint for the parameter: probabilities

Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/joint_probability_distribution.py Outdated


# Function to calculate the expectation (mean)
def expectation(values, probabilities) -> float:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/joint_probability_distribution.py, please provide doctest for the function expectation

Please provide type hint for the parameter: values

Please provide type hint for the parameter: probabilities

Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
@algorithms-keeperalgorithms-keeperBot removed the require type hints https://docs.python.org/3/library/typing.html label Oct 15, 2023

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py Outdated

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@@ -0,0 +1,124 @@
# https://en.wikipedia.org/wiki/Joint_probability_distribution
# Function to calculate the joint probability distribution
def calculate_joint_probability(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/joint_probability_distribution.py, please provide doctest for the function calculate_joint_probability

Comment threadmaths/joint_probability_distribution.py
Comment threadmaths/joint_probability_distribution.py Outdated
Comment threadmaths/joint_probability_distribution.py
Comment threadmaths/joint_probability_distribution.py Outdated
@algorithms-keeperalgorithms-keeperBot removed the require type hints https://docs.python.org/3/library/typing.html label Oct 15, 2023

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/joint_probability_distribution.py Outdated
@algorithms-keeperalgorithms-keeperBot removed the require tests Tests [doctest/unittest/pytest] are required label Oct 15, 2023
@cclauss

Copy link
Copy Markdown
Member

Please revert all changes to maths/maclaurin_series.py

@algorithms-keeperalgorithms-keeperBot added the require tests Tests [doctest/unittest/pytest] are required label Oct 15, 2023

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/joint_probability_distribution.py


# Function to calculate the standard deviation
def standard_deviation(variance: list) -> float:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/joint_probability_distribution.py, please provide doctest for the function standard_deviation

@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 15, 2023

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/joint_probability_distribution.py
Comment threadmaths/joint_probability_distribution.py
@algorithms-keeperalgorithms-keeperBot removed the require tests Tests [doctest/unittest/pytest] are required label Oct 15, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 15, 2023
@cclauss
cclauss merged commit b5474ab into TheAlgorithms:masterOct 15, 2023
@isidroasisidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@leonado10000@cclauss