Skip to content

Hacktoberfest: Added Octal Number to Hexadecimal Number Conversion Algorithm - #10533

Merged
tianyizheng02 merged 8 commits into
TheAlgorithms:masterfrom
developer-kush:master
Oct 17, 2023
Merged

Hacktoberfest: Added Octal Number to Hexadecimal Number Conversion Algorithm#10533
tianyizheng02 merged 8 commits into
TheAlgorithms:masterfrom
developer-kush:master

Conversation

@developer-kush

Copy link
Copy Markdown
Contributor

…ectory

Describe your change:

Added Octal Number to Hexadecimal Number Conversion Algorithm under 'conversions' directory

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 15, 2023
@developer-kushdeveloper-kush changed the title Added Octal Number to Hexadecimal Number Conversion AlgorithmHacktoberfest: Added Octal Number to Hexadecimal Number Conversion AlgorithmOct 15, 2023
@developer-kush

Copy link
Copy Markdown
ContributorAuthor

Hi, this is my first contribution for Hacktoberfest. Please add hacktoberfest label upon merging

Comment threadconversions/octal_to_hexadecimal.py Outdated
Comment threadconversions/octal_to_hexadecimal.py
Comment threadconversions/octal_to_hexadecimal.py Outdated
Comment threadconversions/octal_to_hexadecimal.py Outdated
Comment threadconversions/octal_to_hexadecimal.py Outdated
developer-kushand others added 4 commits October 15, 2023 20:51
fix: minor improvement to directly return hexadecimal value
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
fix: improvement updates to octal to hexadecimal
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
fix: Readablility improvements to octal to hexadecimal convertor
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
fix: readability improvements in octal_to_hexadecimal.py
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadconversions/octal_to_hexadecimal.py
@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 15, 2023
fix: readability improvements in octal_to_hexadecimal.py
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadconversions/octal_to_hexadecimal.py
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 15, 2023
Comment threadconversions/octal_to_hexadecimal.py Outdated
@developer-kush

Copy link
Copy Markdown
ContributorAuthor

@tianyizheng02 I have added the requested changes. Also, I aligned the tests accordingly, so that they do match with the expected output format "0x"+Hex_value

@tianyizheng02
tianyizheng02 merged commit c6c3bd3 into TheAlgorithms:masterOct 17, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 17, 2023
@developer-kush

Copy link
Copy Markdown
ContributorAuthor

Hi, @tianyizheng02 Can you please put hacktoberfest-accepted label on this pull request

@tianyizheng02

Copy link
Copy Markdown
Contributor

This repo already has the Hacktoberfest label, so there should be no need to label individual PRs. You should see this PR's status reflected on your Hacktoberfest profile shortly.

@isidroasisidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@developer-kush@tianyizheng02