Skip to content

[ADD]: Improved tests in power recursion! - #10664

Merged
cclauss merged 12 commits into
TheAlgorithms:masterfrom
imSanko:master
Oct 20, 2023
Merged

[ADD]: Improved tests in power recursion!#10664
cclauss merged 12 commits into
TheAlgorithms:masterfrom
imSanko:master

Conversation

@imSanko

@imSankoimSanko commented Oct 18, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

[ADD]: New test cases for all_combinations !

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Add test cases

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new Python files are placed inside an existing directory.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "FixesImprove our test coverage #9943".

@algorithms-keeperalgorithms-keeperBot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 18, 2023
@imSankoimSanko changed the title [ADD]: Inproved Tests[ADD]: Improved tests in power recursion!Oct 19, 2023
@imSanko

imSanko commented Oct 19, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@tianyizheng02 can you have a look

@imSankoimSanko closed this Oct 19, 2023
@imSankoimSanko reopened this Oct 19, 2023
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 19, 2023
@cclausscclauss self-assigned this Oct 19, 2023
cclauss
cclauss requested changes Oct 19, 2023
View reviewed changes

@cclausscclauss left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests should either add/improve tests or should change the code. This PR changes both the tests and the code. This makes the PR much more difficult to review.

Please revert the change to the algorithm and the change of the filename. Let's have this pull request JUST focus on improving the testing.

@tianyizheng02 Perhaps we need to talk more in CONTRIBUTING.md about not changing both code and tests in a single PR.

@algorithms-keeperalgorithms-keeperBot added awaiting changes A maintainer has requested changes to this PR awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed awaiting changes A maintainer has requested changes to this PR labels Oct 19, 2023
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 19, 2023
@imSanko
imSanko requested a review from cclaussOctober 19, 2023 09:30
@imSanko

imSanko commented Oct 20, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss can you check the change, cause I've made the as per your choice.

@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 20, 2023
@cclauss
cclauss merged commit 4154428 into TheAlgorithms:masterOct 20, 2023
@imSanko

imSanko commented Oct 20, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss can you please add #hacktoberfest-accepted label.

@cclausscclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 20, 2023
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

@cclausscclauss

Labels

enhancementThis PR modified some existing fileshacktoberfest-acceptedAccepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve our test coverage

2 participants

@imSanko@cclauss