Uh oh!
There was an error while loading. Please reload this page.
Increase code coverage for dijkstra algorithm - #10695
Conversation
Refactor to pass mypy
cclauss
commented
Oct 19, 2023
In the commit message above, what does the second checked bullet say? |
r055a
commented
Oct 19, 2023
Thank you @cclauss for the feedback. Are you referring to the PR comment? I may have misinterpreted. I made changes to some variable names for readability. I have removed the tick. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
r055a
commented
Oct 21, 2023
Hi @cclauss I have removed code changes in this PR so that only doctests remain with exception for a bug fix in the min_heapify method. Considering method doc strings are used for the doctests, I have also moved method description comments into these. |
r055a
commented
Oct 27, 2023
Hi @cclauss is there any possibility of this PR being merged soon as I would prefer it to be so before continuing with code changes in a new PR |
cclauss
left a comment
There was a problem hiding this comment.
Please make PriorityQueue a https://docs.python.org/3/library/dataclasses.html
Describe your change:
Ref #9943
Add doctests to
dijkstra_algorithm.pyto improve code coverageBug fixed where required to execute and pass doctests
Moved method declaration comments to doc strings for methods doc strings are added to for the doctests
Checklist: