Skip to content

add exponential search algorithm - #10732

Merged
cclauss merged 18 commits into
TheAlgorithms:masterfrom
kiarash8112:master
Oct 21, 2023
Merged

add exponential search algorithm#10732
cclauss merged 18 commits into
TheAlgorithms:masterfrom
kiarash8112:master

Conversation

@kiarash8112

Copy link
Copy Markdown
Contributor

Describe your change:

added exponential algorithm using binary_search_recursion also tests and docs about it

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 20, 2023
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Oct 20, 2023

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

For optional extra credit, add a timeit benchmark to show relative performance.

Comment threadsearches/binary_search.py
Comment threadsearches/binary_search.py Outdated
Comment threadsearches/binary_search.py Outdated
return binary_search_by_recursion(sorted_collection, item, midpoint + 1, right)


def exponential_search(sorted_collection: list[int], item: int) -> int | None:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a fan of functions that return multiple datatypes. If the search fails, let's return -1 (like "Hello".find("Z")) or raise a ValueError (like "Hello".index("Z")).

Suggested change
defexponential_search(sorted_collection: list[int], item: int) ->int|None:
defexponential_search(sorted_collection: list[int], item: int) ->int:

Comment threadsearches/binary_search.py Outdated
@algorithms-keeperalgorithms-keeperBot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 21, 2023
@cclausscclauss self-assigned this Oct 21, 2023
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 21, 2023
kiarash8112and others added 4 commits October 21, 2023 02:47
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 21, 2023
Comment threadsearches/binary_search.py Outdated
Comment threadsearches/binary_search.py Outdated
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 21, 2023
@cclauss

Copy link
Copy Markdown
Member

I thought more about sorting the sorted collection… it is a bad idea. The second item in might be different in the two lists so the function might tell me that is the second item when in my list it is the third item. So, the implementations should raise ValueError on unsorted input.

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really slick addition. Thanks for doing it!

@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 21, 2023
@cclauss
cclauss merged commit b814cf3 into TheAlgorithms:masterOct 21, 2023
@kiarash8112

Copy link
Copy Markdown
ContributorAuthor

@cclauss thank you for your suggestions :)

@tianyizheng02

Copy link
Copy Markdown
Contributor

@cclauss Since exponential search is a different algorithm from binary search, why was it placed in the binary_search.py file? Shouldn't it have gotten its own file?

bound *= 2
left = bound // 2
right = min(bound, len(sorted_collection) - 1)
last_result = binary_search_by_recursion(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tianyizheng02exponential_search() embeds a call to binary_search_by_recursion() but as the benchmarks demonstrate delivers a faster result. Looking at the first commit makes this clearer.

@isidroasisidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kiarash8112@cclauss@tianyizheng02