') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); code enhancement in `sort.double_sort` by Krishna-Singhal · Pull Request #10798 · TheAlgorithms/Python · GitHub
Skip to content

code enhancement in sort.double_sort - #10798

Merged
cclauss merged 9 commits into
TheAlgorithms:masterfrom
Krishna-Singhal:patch-1
Oct 23, 2023
Merged

code enhancement in sort.double_sort#10798
cclauss merged 9 commits into
TheAlgorithms:masterfrom
Krishna-Singhal:patch-1

Conversation

@Krishna-Singhal

@Krishna-SinghalKrishna-Singhal commented Oct 22, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

  • Don't need to return list because list is mutable
  • use advantage of python in swapping
  • filter blank inputs from input list
  • minor changes
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@Krishna-Singhal
don't need to return list because list is mutable
81673c7
* Don't need to return list as list is mutable
* use advantage of python in swapping
* filter blank inputs from input list
* minor changes
@algorithms-keeperalgorithms-keeperBot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 22, 2023
@Krishna-Singhal

Krishna-Singhal commented Oct 22, 2023

Copy link
Copy Markdown
ContributorAuthor

It would help me if you could add label hacktoberfest-accepted, Thanks...

@cclauss

cclauss commented Oct 22, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Let's change line 1 to a commitment to return a tuple:

defdouble_sort(unsorted: list) ->tuple:

Let's change the vague name lst to unsorted which is more self-documenting.

@cclauss

cclauss commented Oct 22, 2023•
edited
Loading

Copy link
Copy Markdown
Member

No label until the tests pass and it is merged. ;-)

As discussed in CONTRIBUTING.md, you can run the build tests on your computer with the command:

python3 -m doctest -v sorts/double_sort.py

@cclausscclauss self-assigned this Oct 22, 2023
@Krishna-Singhal

Krishna-Singhal commented Oct 22, 2023

Copy link
Copy Markdown
ContributorAuthor

As discussed in CONTRIBUTING.md, you can run the build tests on your computer with the command:

python3 -m doctest -v sorts/double_sort.py

All tests are passed on my computer.

@cclauss

cclauss commented Oct 22, 2023

Copy link
Copy Markdown
Member

The functions returns None so the failure on line 807 makes sense to me.
https://github.com/TheAlgorithms/Python/actions/runs/6602527016/job/17934662337?pr=10801#step:6:808

@Krishna-SinghalKrishna-Singhal changed the title Don't need to return list because list is mutablecode enhancement in sort.double_sortOct 22, 2023
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 22, 2023
@Krishna-Singhal

Krishna-Singhal commented Oct 23, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

The functions returns None so the failure on line 807 makes sense to me. https://github.com/TheAlgorithms/Python/actions/runs/6602527016/job/17934662337?pr=10801#step:6:808

@cclauss, could you review now please?

cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
Comment threadsorts/double_sort.py Outdated
cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
Comment threadsorts/double_sort.py Outdated
cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
Comment threadsorts/double_sort.py Outdated
cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
Comment threadsorts/double_sort.py Outdated
cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
Comment threadsorts/double_sort.py Outdated
cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
Comment threadsorts/double_sort.py Outdated
cclauss
cclauss approved these changes Oct 23, 2023
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Thanks for doing this.

@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 23, 2023
@cclauss
cclauss merged commit 417b7ed into TheAlgorithms:masterOct 23, 2023
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

@cclausscclauss

Labels

enhancementThis PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Krishna-Singhal@cclauss