Skip to content

Added doctest, docstring and typehint for sigmoid_function & cost_function - #10828

Merged
tianyizheng02 merged 8 commits into
TheAlgorithms:masterfrom
Suyashd999:master
Oct 26, 2023
Merged

Added doctest, docstring and typehint for sigmoid_function & cost_function#10828
tianyizheng02 merged 8 commits into
TheAlgorithms:masterfrom
Suyashd999:master

Conversation

@Suyashd999

@Suyashd999Suyashd999 commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

Describe your change:

Contributes to #9943

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 23, 2023
AasheeshLikePanner
AasheeshLikePanner reviewed Oct 23, 2023
View reviewed changes
Comment threadmachine_learning/logistic_regression.py
imSanko
imSanko reviewed Oct 25, 2023
View reviewed changes
Comment threadmachine_learning/logistic_regression.py
@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 25, 2023
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 25, 2023
@Suyashd999Suyashd999 changed the title Added doctest for sigmoid_function & cost_functionAdded doctest, docstring and typehint for sigmoid_function & cost_functionOct 25, 2023
@Suyashd999

Suyashd999 commented Oct 26, 2023

Copy link
Copy Markdown
ContributorAuthor

Hey @tianyizheng02 , @cclauss , can you guys please review this PR? Thanks in advance!

cclauss
cclauss previously requested changes Oct 26, 2023
View reviewed changes
Comment threadmachine_learning/logistic_regression.py Outdated
Comment threadmachine_learning/logistic_regression.py Outdated
@algorithms-keeperalgorithms-keeperBot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 26, 2023
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 26, 2023
@Suyashd999

Suyashd999 commented Oct 26, 2023

Copy link
Copy Markdown
ContributorAuthor

hey @cclauss , I made the changes that you mentioned.

tianyizheng02
tianyizheng02 approved these changes Oct 26, 2023
View reviewed changes
Comment threadmachine_learning/logistic_regression.py Outdated
Comment threadmachine_learning/logistic_regression.py Outdated
@tianyizheng02
tianyizheng02 dismissed cclauss’s stale reviewOctober 26, 2023 07:55

Requested changes already made

@tianyizheng02
tianyizheng02 merged commit dd7d18d into TheAlgorithms:masterOct 26, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 26, 2023
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyizheng02tianyizheng02tianyizheng02 approved these changes
@cclausscclaussAwaiting requested review from cclauss
+2 more reviewers
@imSankoimSankoimSanko left review comments
@AasheeshLikePannerAasheeshLikePannerAasheeshLikePanner left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementThis PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Suyashd999@cclauss@tianyizheng02@imSanko@AasheeshLikePanner