Skip to content

Validate Python filenames - #1086

Merged
AnshulMalik merged 1 commit into
TheAlgorithms:masterfrom
cclauss:validate-filenames
Jul 30, 2019
Merged

Validate Python filenames#1086
AnshulMalik merged 1 commit into
TheAlgorithms:masterfrom
cclauss:validate-filenames

Conversation

@cclauss

@cclausscclauss commented Jul 28, 2019

Copy link
Copy Markdown
Member

Fixes#1005

Add scripts/validate_filenames.py which is run in our automated testing to ensure that all Python filenames contain no uppercase characters, no spaces, and are inside of at least one directory.

Rename the two existing code files that violate these rules.

@cclausscclauss added the awaiting reviews This PR is ready to be reviewed label Jul 28, 2019
@cclauss
cclaussforce-pushed the validate-filenames branch from 2e8f49a to edb7120CompareJuly 28, 2019 18:22
@cclauss
cclauss requested a review from AnshulMalikJuly 30, 2019 07:32

@AnshulMalikAnshulMalik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@AnshulMalik
AnshulMalik merged commit a9ecdb3 into TheAlgorithms:masterJul 30, 2019
@cclauss
cclauss deleted the validate-filenames branch July 30, 2019 11:04
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviewsThis PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Travis CI: Add flake8-filename to our testing

2 participants

@cclauss@AnshulMalik