Skip to content

Create ipv4_conversion.py - #11008

Merged
cclauss merged 6 commits into
TheAlgorithms:masterfrom
its-tapas:patch-6
Oct 28, 2023
Merged

Create ipv4_conversion.py#11008
cclauss merged 6 commits into
TheAlgorithms:masterfrom
its-tapas:patch-6

Conversation

@its-tapas

@its-tapasits-tapas commented Oct 26, 2023•
edited by cclauss
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

Closes#9718
Closes#11013

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 26, 2023
@algorithms-keeperalgorithms-keeperBot mentioned this pull request Oct 26, 2023
Closed
15 tasks
cclauss
cclauss reviewed Oct 26, 2023
View reviewed changes
Comment threadconversions/ipconversion.py Outdated
cclauss
cclauss reviewed Oct 26, 2023
View reviewed changes
Comment threadconversions/ipconversion.py Outdated
'10.0.0.255'
"""

if not (0 <= decimal_ip <= 4294967295):

@cclausscclaussOct 26, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would not catch 10.0.0.256 which is not a valid IP.

its-tapas

This comment was marked as off-topic.

Sign in to view

cclauss
cclauss reviewed Oct 26, 2023
View reviewed changes
Comment threadconversions/ipconversion.py Outdated
for part in ip_parts:
decimal_ip = (decimal_ip << 8) + int(part)

return decimal_ip

@cclausscclaussOct 26, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

def alt_ip_to_decimal(ip_address: str) -> int:
return int("0x" + "".join(f"{int(i):02x}" for i in ip_address.split(".")), 16)

@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 26, 2023
@cclausscclauss self-assigned this Oct 27, 2023
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 28, 2023
@cclausscclauss changed the title Create ipconversion.pyCreate ipv4_conversion.pyOct 28, 2023
@cclauss
cclauss enabled auto-merge (squash) October 28, 2023 22:47
cclauss
cclauss approved these changes Oct 28, 2023
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@cclauss
cclauss merged commit aa5c97d into TheAlgorithms:masterOct 28, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 28, 2023
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

@cclausscclauss

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Speedup our eight slowest pytests (one at a time please)

2 participants

@its-tapas@cclauss