Skip to content

Add Binomial Heap - #1146

Merged
cclauss merged 7 commits into
TheAlgorithms:masterfrom
KirilBangachev:KirilBangachev-binomial_heap
Sep 5, 2019
Merged

Add Binomial Heap#1146
cclauss merged 7 commits into
TheAlgorithms:masterfrom
KirilBangachev:KirilBangachev-binomial_heap

Conversation

@KirilBangachev

@KirilBangachevKirilBangachev commented Aug 22, 2019

Copy link
Copy Markdown
Contributor

Implementing the binomial heap data structure.
Reference: Advanced Data Structures, Peter Brass

@KirilBangachev
Binomial Heap
59aec25
Implementation of Binomial Heap. Reference: Advanced Data Structures, Peter Brass
@KirilBangachev
Update binomial_heap.py
949dcd9
@KirilBangachev
Update binomial_heap.py
abc1fd4
@KirilBangachev
Update binomial_heap.py
c9ae550
- Fuller documentation of binomial heap
- Update unit tests
- Replace printing method by overwriting __str__()
@KirilBangachevKirilBangachev changed the title Binomial HeapAdd Binomial HeapSep 3, 2019
cclauss
cclauss requested changes Sep 3, 2019
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add doctests and/or type hints.

Comment threaddata_structures/heap/binomial_heap.py Outdated
cclauss
cclauss reviewed Sep 3, 2019
View reviewed changes
Comment threaddata_structures/heap/binomial_heap.py
cclauss
cclauss reviewed Sep 3, 2019
View reviewed changes
Comment threaddata_structures/heap/binomial_heap.py
cclauss
cclauss reviewed Sep 3, 2019
View reviewed changes
Comment threaddata_structures/heap/binomial_heap.py Outdated
cclauss
cclauss reviewed Sep 3, 2019
View reviewed changes
Comment threaddata_structures/heap/binomial_heap.py
@KirilBangachev
Update binomial_heap.py
af87364
- Added more tests
- Added to the documentation
- Stylistic editing
- mergeHeaps now also returns a reference to the merged heap
- added a preOrder function that returns a list with the preorder of the heap
@cclauss

cclauss commented Sep 4, 2019

Copy link
Copy Markdown
Member

Looks good to me but still needs to appear in our tests
https://travis-ci.org/TheAlgorithms/Python/builds/580553572#L618

@KirilBangachev

KirilBangachev commented Sep 4, 2019

Copy link
Copy Markdown
ContributorAuthor

Looks good to me but still needs to appear in our tests
https://travis-ci.org/TheAlgorithms/Python/builds/580553572#L618

Would it help if I add some doctests in addition to the unit tests?

@cclauss

cclauss commented Sep 4, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Or get the unittests to be recognized by pytest.

cclauss
cclauss approved these changes Sep 5, 2019
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for your persistence.

@cclauss
cclauss merged commit f31a812 into TheAlgorithms:masterSep 5, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@KirilBangachev@stokhos
Add Binomial Heap (TheAlgorithms#1146)
491e8ea
* Binomial Heap
Implementation of Binomial Heap. Reference: Advanced Data Structures, Peter Brass
* Update binomial_heap.py
* Update binomial_heap.py
* Update binomial_heap.py
- Fuller documentation of binomial heap
- Update unit tests
- Replace printing method by overwriting __str__()
* Update binomial_heap.py
- Added more tests
- Added to the documentation
- Stylistic editing
- mergeHeaps now also returns a reference to the merged heap
- added a preOrder function that returns a list with the preorder of the heap
* Update binomial_heap.py
Changed the unit tests structure
* Turned the tests into doctests
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KirilBangachev@cclauss