Performance: 25% faster Project Euler 73 #10503

[RamanaMenda]

Describe your change:

#8594

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
• If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

[RamanaMenda]

Hi @cclauss & @imSanko: Looking forward for your review

[imSanko]

Try some more test such as:

import unittest
class TestSolution(unittest.TestCase):
def test_small_max_d(self):
self.assertEqual(solution(4), 0)
self.assertEqual(solution(5), 1)
self.assertEqual(solution(8), 3)
def test_large_max_d(self):
self.assertEqual(solution(12000), 7193) # Expected result
def test_invalid_input(self):
with self.assertRaises(ValueError):
solution(-1)
with self.assertRaises(ValueError):
solution(0)
if __name__ == "__main__":
unittest.main()

[RamanaMenda]

Describe your change:

#8594

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
• If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

[RamanaMenda]

Hi @cclauss & @imSanko: Looking forward for your review

[imSanko]

Try some more test such as:

import unittest
class TestSolution(unittest.TestCase):
def test_small_max_d(self):
self.assertEqual(solution(4), 0)
self.assertEqual(solution(5), 1)
self.assertEqual(solution(8), 3)
def test_large_max_d(self):
self.assertEqual(solution(12000), 7193) # Expected result
def test_invalid_input(self):
with self.assertRaises(ValueError):
solution(-1)
with self.assertRaises(ValueError):
solution(0)
if __name__ == "__main__":
unittest.main()

[RamanaMenda]

Describe your change:

#8594

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
• If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

[RamanaMenda]

Hi @cclauss & @imSanko: Looking forward for your review

[imSanko]

Try some more test such as:

import unittest
class TestSolution(unittest.TestCase):
def test_small_max_d(self):
self.assertEqual(solution(4), 0)
self.assertEqual(solution(5), 1)
self.assertEqual(solution(8), 3)
def test_large_max_d(self):
self.assertEqual(solution(12000), 7193) # Expected result
def test_invalid_input(self):
with self.assertRaises(ValueError):
solution(-1)
with self.assertRaises(ValueError):
solution(0)
if __name__ == "__main__":
unittest.main()

[RamanaMenda]

Describe your change:

#8594

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
• If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

[RamanaMenda]

Hi @cclauss & @imSanko: Looking forward for your review

[imSanko]

Try some more test such as:

import unittest
class TestSolution(unittest.TestCase):
def test_small_max_d(self):
self.assertEqual(solution(4), 0)
self.assertEqual(solution(5), 1)
self.assertEqual(solution(8), 3)
def test_large_max_d(self):
self.assertEqual(solution(12000), 7193) # Expected result
def test_invalid_input(self):
with self.assertRaises(ValueError):
solution(-1)
with self.assertRaises(ValueError):
solution(0)
if __name__ == "__main__":
unittest.main()

[RamanaMenda]

Describe your change:

#8594

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
• If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

[RamanaMenda]

Hi @cclauss & @imSanko: Looking forward for your review

[imSanko]

Try some more test such as:

import unittest
class TestSolution(unittest.TestCase):
def test_small_max_d(self):
self.assertEqual(solution(4), 0)
self.assertEqual(solution(5), 1)
self.assertEqual(solution(8), 3)
def test_large_max_d(self):
self.assertEqual(solution(12000), 7193) # Expected result
def test_invalid_input(self):
with self.assertRaises(ValueError):
solution(-1)
with self.assertRaises(ValueError):
solution(0)
if __name__ == "__main__":
unittest.main()

[RamanaMenda]

Describe your change:

#8594

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
• If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

[RamanaMenda]

Hi @cclauss & @imSanko: Looking forward for your review

[imSanko]

Try some more test such as:

import unittest
class TestSolution(unittest.TestCase):
def test_small_max_d(self):
self.assertEqual(solution(4), 0)
self.assertEqual(solution(5), 1)
self.assertEqual(solution(8), 3)
def test_large_max_d(self):
self.assertEqual(solution(12000), 7193) # Expected result
def test_invalid_input(self):
with self.assertRaises(ValueError):
solution(-1)
with self.assertRaises(ValueError):
solution(0)
if __name__ == "__main__":
unittest.main()

[RamanaMenda]

Describe your change:

#8594

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
• If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

[RamanaMenda]

Hi @cclauss & @imSanko: Looking forward for your review

[imSanko]

Try some more test such as:

import unittest
class TestSolution(unittest.TestCase):
def test_small_max_d(self):
self.assertEqual(solution(4), 0)
self.assertEqual(solution(5), 1)
self.assertEqual(solution(8), 3)
def test_large_max_d(self):
self.assertEqual(solution(12000), 7193) # Expected result
def test_invalid_input(self):
with self.assertRaises(ValueError):
solution(-1)
with self.assertRaises(ValueError):
solution(0)
if __name__ == "__main__":
unittest.main()