Skip to content

Min head with decrease key functionality - #1202

Merged
cclauss merged 6 commits into
TheAlgorithms:masterfrom
Raj1998:master
Sep 25, 2019
Merged

Min head with decrease key functionality#1202
cclauss merged 6 commits into
TheAlgorithms:masterfrom
Raj1998:master

Conversation

@Raj1998

@Raj1998Raj1998 commented Sep 25, 2019

Copy link
Copy Markdown
Contributor

I have added MinHeap data structure with decrease key function in O(logn) time. I have also added sample usage at the bottom.

Please let me know if there are any changes.

cclauss
cclauss reviewed Sep 25, 2019
View reviewed changes
Comment threaddata_structures/heap/min_heap.py Outdated
@cclauss

cclauss commented Sep 25, 2019

Copy link
Copy Markdown
Member

Please add at least one https://docs.python.org/3/library/doctest.html

cclauss
cclauss requested changes Sep 25, 2019
View reviewed changes

@cclausscclauss left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are getting there but I think one thing that we are missing in the ability to get the value given the key (name) as in print(myMinHeap("X")) # -> 1

Not much value in a heap that you can not get the data back out of ;-)

Comment threaddata_structures/heap/min_heap.py Outdated
Comment threaddata_structures/heap/min_heap.py Outdated
Comment threaddata_structures/heap/min_heap.py
Comment threaddata_structures/heap/min_heap.py
cclauss
cclauss reviewed Sep 25, 2019
View reviewed changes
Comment threaddata_structures/heap/min_heap.py
cclauss
cclauss approved these changes Sep 25, 2019
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Congratulations and thanks!! 🍰

@cclauss
cclauss merged commit 6ac7b13 into TheAlgorithms:masterSep 25, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Raj1998@stokhos
Min head with decrease key functionality (TheAlgorithms#1202)
ca0979b
* Min head with decrease key functionality
* doctest added
* __str__ changed as per Python convention
* edits in doctest
* get_value by key added
* __getitem__ added
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Raj1998@cclauss