Skip to content

Fix And Add power.py - #12567

Merged
MaximSmolskiy merged 9 commits into
TheAlgorithms:masterfrom
lighting9999:patch-2
Feb 9, 2025
Merged

Fix And Add power.py#12567
MaximSmolskiy merged 9 commits into
TheAlgorithms:masterfrom
lighting9999:patch-2

Conversation

@lighting9999

Copy link
Copy Markdown
Contributor

Describe your change:

To fix the inaccuracies and allow handling of negative exponents and bases, the key issue lies in how negative numbers are handled in the power calculation, especially when dividing.

Example Output:

>>>power(4, 6)
4096>>>power(2, 3)
8>>>power(-2, 3)
-8>>>power(2, -3)
0.125>>>power(-2, -3)
-0.125
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

lighting9999and others added 2 commits February 8, 2025 17:48
To fix the inaccuracies and allow handling of negative exponents and bases, the key issue lies in how negative numbers are handled in the power calculation, especially when dividing.
## Example Output:
```python
>>> power(4, 6)
4096
>>> power(2, 3)
8
>>> power(-2, 3)
-8
>>> power(2, -3)
0.125
>>> power(-2, -3)
-0.125
```
@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Feb 8, 2025
@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Feb 8, 2025
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Feb 8, 2025
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Feb 9, 2025
@MaximSmolskiy
MaximSmolskiy merged commit 338cbaf into TheAlgorithms:masterFeb 9, 2025
@lighting9999
lighting9999 deleted the patch-2 branch February 10, 2025 02:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lighting9999@MaximSmolskiy