Uh oh!
There was an error while loading. Please reload this page.
Delete requirements.txt because dependencies are in pyproject.toml - #13486
Merged
Conversation
cclaussforce-pushed
the
delete-requirements.txt
branch
from
October 15, 2025 14:46
cfd4d78 to
5b73ceaComparecclaussforce-pushed
the
delete-requirements.txt
branch
from
October 15, 2025 14:52
0ced413 to
64ef790Comparepoyea
approved these changes
Oct 15, 2025
Uh oh!
There was an error while loading. Please reload this page.
mattmanj17
commented
Nov 19, 2025
CONTRIBUTING.md should be updated to not mention requirements.txt |
15 tasks
cclauss added a commit
that referenced
this pull request
Sep 5, 2026
* docs: fix outdated references in CONTRIBUTING.md - Update Python version from 3.13+ to 3.14+ (matches pyproject.toml) - Replace outdated black formatter recommendation with ruff format (matches .pre-commit-config.yaml) - Update PEP 8 URL to canonical peps.python.org (old URL 302-redirects) - Fix inconsistent mypy URL from http://www.mypy-lang.org to https://mypy-lang.org * docs: point CONTRIBUTING.md at the tooling CI actually runs - `ruff .` -> `ruff check .`: bare `ruff .` fails with "unrecognized subcommand '.'"; .github/workflows/ruff.yml runs `ruff check ... .` - mypy -> ty: the mirrors-mypy pre-commit hook is commented out and no workflow runs mypy, while .github/workflows/ty.yml runs `ty check` on every pull request - requirements.txt -> pyproject.toml: requirements.txt was deleted in #13486 ("dependencies are in pyproject.toml") * docs: note that the ty check is informational Addresses Copilot review feedback: .github/workflows/ty.yml sets `continue-on-error: true` and passes `--exit-zero` ("ty is not yet a required gate"), so the previous wording implied an enforced gate. * Apply batched suggestions from code review Co-authored-by: Christian Clauss <cclauss@me.com> * Fix grammar and punctuation in CONTRIBUTING.md Correct grammar and punctuation throughout the document for clarity and consistency. --------- Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Delete requirements.txt because dependencies are in pyproject.toml
Also, streamline the build based on all the progress on Python 3.14 build wheels.
Checklist: