Implementation of Hardy Ramanujan Algorithm in /maths by alfinwilliam · Pull Request #1355 · TheAlgorithms/Python

alfinwilliam · 2019-10-13T15:25:24Z

Fixes: #1356

cclauss · 2019-10-18T05:29:56Z

Please add doctests as discussed in CONTRIBUTING.md.

alfinwilliam · 2019-10-18T14:27:13Z

Added docstrings & doctests as mentioned in CONTRIBUTING.md

cclauss

doctest please

cclauss · 2019-10-18T22:11:34Z

@@ -0,0 +1,46 @@
+
+#It's a theorem that states the number of prime factors


cclauss · 2019-10-18T22:11:52Z

+
+#It's a theorem that states the number of prime factors
+# of n will approximately be log(log(n)) for most 
+#natural numbers n


# please...

cclauss · 2019-10-18T22:12:13Z

+
+
+def exactPrimeFactorCount(n) : 
+	count = 0


Add a doctest?

cclauss · 2019-10-18T22:13:25Z

+
+def exactPrimeFactorCount(n) : 
+	count = 0
+	if (n % 2 == 0) : 


Remove the ()... This is Python, not JavaScript.

cclauss · 2019-10-18T22:13:47Z

+def exactPrimeFactorCount(n) : 
+	count = 0
+	if (n % 2 == 0) : 
+ count = count + 1


cclauss · 2019-10-18T22:13:59Z

+	count = 0
+	if (n % 2 == 0) : 
+ count = count + 1
+ while (n % 2 == 0) : 


Remove the ()

cclauss · 2019-10-18T22:14:06Z

+
+	i = 3
+
+	while (i <= int(math.sqrt(n))) : 


Remove the ()

cclauss · 2019-10-18T22:14:18Z

+	i = 3
+
+	while (i <= int(math.sqrt(n))) : 
+ if (n % i == 0) : 


Remove the ()

cclauss · 2019-10-18T22:14:40Z

+
+	#this condition checks the prime
+	#number n is greater than 2
+


Remove the ()

cclauss · 2019-10-18T22:14:53Z

+	#number n is greater than 2
+
+	if (n > 2) : 
+ count = count + 1


…1355) * Implementation of Hardy Ramanujan Algorithm * added docstrings * added doctests * Run Python black on the code * Travis CI: Upgrade to Python 3.8 * Revert to Python 3.7

Implementation of Hardy Ramanujan Algorithm
51a7bc8

alfinwilliam mentioned this pull request Oct 13, 2019
Merge implementation of Hardy_Ramanujan Algorithm in /maths #1356
Closed

alfinwilliam added 2 commits October 18, 2019 19:52

added docstrings
8b50782

added doctests
138bc15

cclauss requested changes Oct 18, 2019
View reviewed changes

alfinwilliam closed this Oct 19, 2019

cclauss reopened this Oct 19, 2019

cclauss added 3 commits October 19, 2019 05:57

Run Python black on the code
b528a5f

Travis CI: Upgrade to Python 3.8
cbefb89

Revert to Python 3.7
759ff22

cclauss approved these changes Oct 19, 2019
View reviewed changes

cclauss merged commit 5c351d8 into TheAlgorithms:masterOct 19, 2019

		@@ -0,0 +1,46 @@

		#It's a theorem that states the number of prime factors

Uh oh!

Uh oh!

Conversation

alfinwilliam commented Oct 13, 2019• edited by cclauss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cclauss commented Oct 18, 2019

Uh oh!

alfinwilliam commented Oct 18, 2019

Uh oh!

cclauss left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alfinwilliam commented Oct 13, 2019•
edited by cclauss
Loading