Uh oh!
There was an error while loading. Please reload this page.
Create ActivitySelection - #1384
Merged
Merged
Conversation
cclauss
requested changes
Oct 17, 2019
cclauss
left a comment
Member
There was a problem hiding this comment.
- Filename does not end in .py
- Filename contains capital letters
- File contains legacy print statements
- No doctests or type hints
cclauss
commented
Oct 17, 2019
Member
One step forward... Please keep it up. Make sure the Travis tests are passing. |
cclauss
commented
Oct 17, 2019
Member
https://travis-ci.com/TheAlgorithms/Python/builds/132386235#L351 Rename the file to other/activity_selection.py |
cclauss
requested changes
Oct 18, 2019
Uh oh!
There was an error while loading. Please reload this page.
cclauss
commented
Oct 18, 2019
Member
stokhos pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Create ActivitySelection * Update and rename ActivitySelection to activity_selection.py * Update activity_selection.py * Update activity_selection.py * Update activity_selection.py * Update activity_selection.py * Update activity_selection.py * Update activity_selection.py * Rename activity_selection.py to other/activity_selection.py * Update activity_selection.py * Update activity_selection.py * Add a doctest * print(j, end=" ") * print(i, end=" ") * colons * Add trailing space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.