Skip to content

Python program that surfs 3 site at a time - #1389

Merged
cclauss merged 10 commits into
TheAlgorithms:masterfrom
Kunal614:master
Oct 18, 2019
Merged

Python program that surfs 3 site at a time#1389
cclauss merged 10 commits into
TheAlgorithms:masterfrom
Kunal614:master

Conversation

@Kunal614

Copy link
Copy Markdown
Contributor

add input in the compiling time like -- python3 project1.py (man)

add input in the compiling time like -- python3 project1.py (man)
@cclausscclauss added the tests are failing Do not merge until tests pass label Oct 18, 2019

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated tests are failing. See CONTRIBUTING.md for details.

Comment threadproject1.py Outdated
#from urllib.request import urlopen
import webbrowser
import sys
from fake_useragent import UserAgent

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain I don't understand what to do and how to do.

@Kunal614Kunal614Oct 18, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get error

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment out the line that it is complaining about and then see if the script still runs. flake8 is saying that the import is not needed.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment out the line that it is complaining about and then see if the script still runs. flake8 is saying that the import is not needed.

commented

@Kunal614

Kunal614 commented Oct 18, 2019 via email

Copy link
Copy Markdown
ContributorAuthor

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tweeks made but now it is ready to land. Thanks!

@cclauss
cclauss merged commit 43f99e5 into TheAlgorithms:masterOct 18, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Python program that scrufs 3 site at a time
add input in the compiling time like -- python3 project1.py (man)
* Update project1.py
* noqa: F401 and reformat with black
* Rename project1.py to web_programming/crawl_google_results.py
* Add beautifulsoup4 to requirements.txt
* Add fake_useragent to requirements.txt
* Update crawl_google_results.py
* headers={"UserAgent": UserAgent().random}
* html.parser, not lxml
* link, not links
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests are failingDo not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Kunal614@cclauss