Skip to content

Largest subarray sum - #1404

Merged
cclauss merged 10 commits into
TheAlgorithms:masterfrom
anubhav-sharma13:master
Oct 22, 2019
Merged

Largest subarray sum#1404
cclauss merged 10 commits into
TheAlgorithms:masterfrom
anubhav-sharma13:master

Conversation

@anubhav-sharma13

@anubhav-sharma13anubhav-sharma13 commented Oct 19, 2019•
edited by cclauss
Loading

Copy link
Copy Markdown
Contributor

It contains the code of how to find the largest subarray sum in Python.

@cclauss

cclauss commented Oct 19, 2019

Copy link
Copy Markdown
Member

Travis CI tests are failing. See CONTRIBUTING.md for details.

This repo no longer supports legacy Python. print() is a function in Python 3.

https://travis-ci.com/TheAlgorithms/Python/builds/132670589#L352

@cclausscclauss added the tests are failing Do not merge until tests pass label Oct 19, 2019
cclauss
cclauss requested changes Oct 19, 2019
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print()

cclauss
cclauss reviewed Oct 21, 2019
View reviewed changes
Comment threadother/largest_subarray_sum.py Outdated
cclauss
cclauss reviewed Oct 21, 2019
View reviewed changes
Comment threadsorts/i_sort.py Outdated
cclauss
cclauss reviewed Oct 21, 2019
View reviewed changes
Comment threadsorts/i_sort.py Outdated
@cclauss

cclauss commented Oct 21, 2019

Copy link
Copy Markdown
Member

sys.maxint was removed in Python 3 because all integers are of infinite precision.
https://docs.python.org/3/whatsnew/3.0.html#integers

@cclauss

cclauss commented Oct 21, 2019

Copy link
Copy Markdown
Member

This is what a Pythonic function name, type hints, a doctest, and a default argument would look like.

defmax_sub_array_sum(a: list, size: int=0):
""" >>> max_sub_array_sum([-13, -3, -25, -20, -3, -16, -23, -12, -5, -22, -15, -4, -7]) -3 """size=sizeorlen(a)

@cclauss

cclauss commented Oct 21, 2019

Copy link
Copy Markdown
Member

https://travis-ci.com/TheAlgorithms/Python/builds/132847594#L544

@anubhav-sharma13

anubhav-sharma13 commented Oct 21, 2019

Copy link
Copy Markdown
ContributorAuthor

It is working on my system but the travis CI test failed

@cclauss

cclauss commented Oct 21, 2019

Copy link
Copy Markdown
Member

On your system, what happens when you type:

  • python3 -m doctest largest_subarray_sum.py
  • python3 -m doctest -v largest_subarray_sum.py

@cclauss

cclauss commented Oct 21, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Doctests are just docstrings until you run python3 -m doctest on them and then they turn into tests!

The problem that Travis is complaining about is that the doctest is using a Pythonic function name but the code is using a JavaScript-style function name.

cclauss
cclauss reviewed Oct 22, 2019
View reviewed changes
Comment threadother/largest_subarray_sum.py
def maxSubArraySum(a: list, size: int = 0):
def max_Sub_Array_Sum(a: list, size: int = 0):
"""
>>> max_sub_array_sum([-13, -3, -25, -20, -3, -16, -23, -12, -5, -22, -15, -4, -7])

@cclausscclaussOct 22, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s be Pythonic and use max_sub_array_sum everywhere.

@cclauss
cclauss merged commit ce7faa5 into TheAlgorithms:masterOct 22, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@anubhav-sharma13@stokhos
Largest subarray sum (TheAlgorithms#1404)
af0fa1a
* Insertion_sort
* largest subarray sum
* updated print command
* removed extraspaces
* removed sys.maxint
* added explaination
* Updated function style
* Update largest_subarray_sum.py
* Update i_sort.py
* Delete bogo_bogo_sort.py
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

tests are failingDo not merge until tests pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anubhav-sharma13@cclauss