Skip to content

add simple improved Sieve Of Eratosthenes Algorithm - #1412

Merged
cclauss merged 3 commits into
TheAlgorithms:masterfrom
ShuLaPy:add-SieveOfEratosthenes2
Oct 21, 2019
Merged

add simple improved Sieve Of Eratosthenes Algorithm#1412
cclauss merged 3 commits into
TheAlgorithms:masterfrom
ShuLaPy:add-SieveOfEratosthenes2

Conversation

@ShuLaPy

Copy link
Copy Markdown
Contributor

No description provided.

@cclausscclauss added the tests are failing Do not merge until tests pass label Oct 21, 2019
@cclauss

Copy link
Copy Markdown
Member

Comment threadmaths/SieveOfEratosthenesPrimeNumber.py
@cclauss

Copy link
Copy Markdown
Member

https://travis-ci.com/TheAlgorithms/Python/builds/132872849#L365
1 files contain uppercase characters:
maths/SieveOfEratosthenesPrimeNumber.py

@cclauss

Copy link
Copy Markdown
Member

This check is on the filename, not function name (although that is good too).

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!!

@cclauss
cclauss merged commit a06995a into TheAlgorithms:masterOct 21, 2019
@ShuLaPy

Copy link
Copy Markdown
ContributorAuthor

Thank you very much this is my first successful contribution.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* add simple improved Sieve Of Eratosthenes Algorithm
* added doctests
* name changed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests are failingDo not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ShuLaPy@cclauss