Skip to content

introduced shuffled_shift_cipher.py in /ciphers - #1424

Merged
cclauss merged 5 commits into
TheAlgorithms:masterfrom
chttrjeankr:shuffled_shift_cipher
Oct 23, 2019
Merged

introduced shuffled_shift_cipher.py in /ciphers#1424
cclauss merged 5 commits into
TheAlgorithms:masterfrom
chttrjeankr:shuffled_shift_cipher

Conversation

@chttrjeankr

@chttrjeankrchttrjeankr commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

a modified shift cipher algorithm with the explanation in the docstrings

cclauss
cclauss requested changes Oct 23, 2019
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need at least one function or method to have doctests. See CONTRIBUTING.md.

Also, what about some type hints (also see CONTRIBUTING.md).

Comment threadciphers/shuffled_shift_cipher.py Outdated
Comment threadciphers/shuffled_shift_cipher.py
Comment threadciphers/shuffled_shift_cipher.py Outdated
Comment threadciphers/shuffled_shift_cipher.py Outdated
Comment threadciphers/shuffled_shift_cipher.py Outdated
Comment threadciphers/shuffled_shift_cipher.py Outdated
Comment threadciphers/shuffled_shift_cipher.py Outdated
cclauss
cclauss reviewed Oct 23, 2019
View reviewed changes
Comment threadciphers/shuffled_shift_cipher.py Outdated
@chttrjeankr
introduced doctests, type hints
95fe810
removed __make_one_digit()
cclauss
cclauss reviewed Oct 23, 2019
View reviewed changes
Comment threadciphers/shuffled_shift_cipher.py Outdated
@chttrjeankr

chttrjeankr commented Oct 23, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks for helping out with this commit. 👍
I was a bit confused about how to frame the doctests. 😕

Any other changes needed for this PR or is everything set now?

cclauss
cclauss approved these changes Oct 23, 2019
View reviewed changes

@cclausscclauss left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!! Congratulations. I made one minor mod on line 171 to test the return value.

Thanks much!

@cclauss
cclauss merged commit d477a4d into TheAlgorithms:masterOct 23, 2019
@cclauss

cclauss commented Oct 23, 2019

Copy link
Copy Markdown
Member

This was our 1,000th PR closed.

@chttrjeankr

chttrjeankr commented Oct 23, 2019

Copy link
Copy Markdown
ContributorAuthor

Loved the prompt response and reviews I got for my PRs for the last two days. 👍 This was one of my first useful contributions in the open-source community and the experience has left me wanting to contribute more and more. 😄

The 1,000th PR will be a milestone to remember for me. 🎉 🎉

@TheAlgorithmsTheAlgorithms deleted a comment from tootsieTianOct 23, 2019
@chttrjeankr
chttrjeankr deleted the shuffled_shift_cipher branch October 23, 2019 18:36
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@chttrjeankr@stokhos
introduced shuffled_shift_cipher.py in /ciphers (TheAlgorithms#1424)
418f412
* introduced shuffled_shift_cipher.py in /ciphers
* made requested changes
* introduced doctests, type hints
removed __make_one_digit()
* test_end_to_end() inserted
* Make test_end_to_end() a test ;-)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chttrjeankr@cclauss