Uh oh!
There was an error while loading. Please reload this page.
feat: add 10 graph algorithms with tests - #14824
Conversation
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| Solve Chinese Postman Problem for weighted undirected graphs. | ||
| """ | ||
| def __init__(self, n: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as:def function() -> None:
Please provide descriptive name for the parameter: n
| self.adj: list[list[tuple[int, int]]] = [[] for _ in range(n)] | ||
| self.total_weight = 0 | ||
| def add_edge(self, u: int, v: int, w: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: u
Please provide descriptive name for the parameter: v
Please provide descriptive name for the parameter: w
| def chinese_postman( | ||
| n: int, edges: list[tuple[int, int, int]] |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
| import random | ||
| import time | ||
| def benchmark(): |
There was a problem hiding this comment.
Please provide return type hint for the function: benchmark. If the function does not return a value, please provide the type hint as:def function() -> None:
| Maximum flow using Ford-Fulkerson with Edmonds-Karp (BFS). | ||
| """ | ||
| def __init__(self, n: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as:def function() -> None:
Please provide descriptive name for the parameter: n
| self.rev_graph[b].append(not_a) | ||
| self.rev_graph[a].append(not_b) | ||
| def add_implication(self, i: int, val_i: bool, j: int, val_j: bool) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: i
Please provide descriptive name for the parameter: j
| self.graph[a].append(b) | ||
| self.rev_graph[b].append(a) | ||
| def add_nand(self, i: int, val_i: bool, j: int, val_j: bool) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: i
Please provide descriptive name for the parameter: j
| visited = [False] * n | ||
| order = [] | ||
| def dfs1(u: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: dfs1. If the function does not return a value, please provide the type hint as:def function() -> None:
Please provide descriptive name for the parameter: u
| component = [-1] * n | ||
| current_comp = 0 | ||
| def dfs2(u: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: dfs2. If the function does not return a value, please provide the type hint as:def function() -> None:
Please provide descriptive name for the parameter: u
| return assignment | ||
| def solve_2sat(n: int, clauses: list[tuple[int, bool, int, bool]]) -> list[bool] | None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
931f735 to
e2883d5CompareThere was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| def fix_chinese_postman(): | ||
| p = Path("graphs/chinese_postman.py") |
There was a problem hiding this comment.
Please provide return type hint for the function: fix_chinese_postman. If the function does not return a value, please provide the type hint as:def function() -> None:
| def fix_ford_fulkerson(): | ||
| p = Path("graphs/ford_fulkerson.py") | ||
| text = p.read_text() | ||
There was a problem hiding this comment.
Please provide return type hint for the function: fix_ford_fulkerson. If the function does not return a value, please provide the type hint as:def function() -> None:
| text = p.read_text() | ||
| text = text.replace(' def benchmark():', ' def benchmark() -> None:') | ||
There was a problem hiding this comment.
Please provide return type hint for the function: fix_floyd_warshall. If the function does not return a value, please provide the type hint as:def function() -> None:
| text = p.read_text() | ||
| text = text.replace('def dfs1(u: int):', 'def dfs1(u: int) -> None:') | ||
| text = text.replace('def dfs2(u: int):', 'def dfs2(u: int) -> None:') |
There was a problem hiding this comment.
Please provide return type hint for the function: fix_two_sat. If the function does not return a value, please provide the type hint as:def function() -> None:
| text = p.read_text() | ||
| # Fix johnson test expectation | ||
| text = text.replace('assert dist[0][4] == -1', 'assert dist[0][4] == 0') |
There was a problem hiding this comment.
Please provide return type hint for the function: fix_test_graph_algorithms. If the function does not return a value, please provide the type hint as:def function() -> None:
| self.rev_graph[b].append(not_a) | ||
| self.rev_graph[a].append(not_b) | ||
| def add_implication(self, i: int, val_i: bool, j: int, val_j: bool) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: i
Please provide descriptive name for the parameter: j
| self.graph[a].append(b) | ||
| self.rev_graph[b].append(a) | ||
| def add_nand(self, i: int, val_i: bool, j: int, val_j: bool) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: i
Please provide descriptive name for the parameter: j
| visited = [False] * n | ||
| order = [] | ||
| def dfs1(u: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: u
| component = [-1] * n | ||
| current_comp = 0 | ||
| def dfs2(u: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: u
| return assignment | ||
| def solve_2sat(n: int, clauses: list[tuple[int, bool, int, bool]]) -> list[bool] | None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
3e034f7 to
a6ac5acCompareThere was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| Solve Chinese Postman Problem for weighted undirected graphs. | ||
| """ | ||
| def __init__(self, n: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
| self.adj: list[list[tuple[int, int]]] = [[] for _ in range(n)] | ||
| self.total_weight = 0 | ||
| def add_edge(self, u: int, v: int, w: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: u
Please provide descriptive name for the parameter: v
Please provide descriptive name for the parameter: w
| def chinese_postman( | ||
| n: int, edges: list[tuple[int, int, int]] |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
| Maximum flow using Ford-Fulkerson with Edmonds-Karp (BFS). | ||
| """ | ||
| def __init__(self, n: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
| self.capacity: list[list[int]] = [[0] * n for _ in range(n)] | ||
| self.flow: list[list[int]] = [[0] * n for _ in range(n)] | ||
| def add_edge(self, u: int, v: int, cap: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: u
Please provide descriptive name for the parameter: v
| self.rev_graph[b].append(not_a) | ||
| self.rev_graph[a].append(not_b) | ||
| def add_implication(self, i: int, val_i: bool, j: int, val_j: bool) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: i
Please provide descriptive name for the parameter: j
| self.graph[a].append(b) | ||
| self.rev_graph[b].append(a) | ||
| def add_nand(self, i: int, val_i: bool, j: int, val_j: bool) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: i
Please provide descriptive name for the parameter: j
| visited = [False] * n | ||
| order = [] | ||
| def dfs1(u: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: u
| component = [-1] * n | ||
| current_comp = 0 | ||
| def dfs2(u: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: u
| return assignment | ||
| def solve_2sat(n: int, clauses: list[tuple[int, bool, int, bool]]) -> list[bool] | None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
0a7b85e to
7972009Compare
Implemented algorithms: - Floyd-Warshall (all-pairs shortest path) - Johnson's Algorithm (sparse graph all-pairs) - Hopcroft-Karp (maximum bipartite matching) - Ford-Fulkerson with Edmonds-Karp (max flow) - Push-Relabel (max flow) - 2-SAT Solver - Chinese Postman Problem - Traveling Salesman (Held-Karp) - Heavy-Light Decomposition - Maximum Bipartite Independent Set All include: - Type hints and docstrings with complexity analysis - Doctests with examples - Comprehensive pytest test suite
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| Solve Chinese Postman Problem for weighted undirected graphs. | ||
| """ | ||
| def __init__(self, n: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
| self.adj: list[list[tuple[int, int]]] = [[] for _ in range(n)] | ||
| self.total_weight = 0 | ||
| def add_edge(self, u: int, v: int, w: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: u
Please provide descriptive name for the parameter: v
Please provide descriptive name for the parameter: w
| def chinese_postman( | ||
| n: int, edges: list[tuple[int, int, int]] |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
| Maximum flow using Ford-Fulkerson with Edmonds-Karp (BFS). | ||
| """ | ||
| def __init__(self, n: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
| self.capacity: list[list[int]] = [[0] * n for _ in range(n)] | ||
| self.flow: list[list[int]] = [[0] * n for _ in range(n)] | ||
| def add_edge(self, u: int, v: int, cap: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: u
Please provide descriptive name for the parameter: v
| self.rev_graph[b].append(not_a) | ||
| self.rev_graph[a].append(not_b) | ||
| def add_implication(self, i: int, val_i: bool, j: int, val_j: bool) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: i
Please provide descriptive name for the parameter: j
| self.graph[a].append(b) | ||
| self.rev_graph[b].append(a) | ||
| def add_nand(self, i: int, val_i: bool, j: int, val_j: bool) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: i
Please provide descriptive name for the parameter: j
| visited = [False] * n | ||
| order = [] | ||
| def dfs1(u: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: u
| component = [-1] * n | ||
| current_comp = 0 | ||
| def dfs2(u: int) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: u
| return assignment | ||
| def solve_2sat(n: int, clauses: list[tuple[int, bool, int, bool]]) -> list[bool] | None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
cclauss
commented
Sep 2, 2026
Closing require_type_hints PRs to prepare for Hacktoberfest |
Description
Implements 10 advanced graph algorithms with comprehensive tests.
Algorithms Added
Checklist