Uh oh!
There was an error while loading. Please reload this page.
feat: add MinHash Jaccard similarity estimator - #14973
Conversation
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| from collections.abc import Iterable, Sequence | ||
| def _token_hash(token: str, seed: int, permutation: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/min_hash.py, please provide doctest for the function _token_hash
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| from collections.abc import Iterable, Sequence | ||
| def _token_hash(token: str, seed: int, permutation: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/min_hash.py, please provide doctest for the function _token_hash
Describe your change:
Checklist:
Summary
Adds a dependency-free MinHash implementation for estimating Jaccard similarity from token sets. The implementation uses seeded BLAKE2b-derived permutations for deterministic signatures, validates inputs, and documents the algorithm with references.
MinHash is useful for near-duplicate detection, similarity search, and information-retrieval experiments where exact set comparisons are expensive.
Validation
python3 -m doctest -v machine_learning/min_hash.py— 7 tests passed.