Fix tree_sort dropping duplicate values - #15381
Open
Darkslayer3324j wants to merge 1 commit into
Open
Darkslayer3324j wants to merge 1 commit into
Darkslayer3324j wants to merge 1 commit into
Conversation
Node.insert ignored values equal to the current node, so tree_sort([1, 1]) returned (1,). Send equal values to the right subtree and add doctests for repeated values. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
tree_sortsilently drops repeated values, so it is not a sort of its input:Node.insertonly handlesval < self.valandval > self.val; a value equal to the node is ignored. The fix sends equal values to the right subtree so every element is kept. Doctests for repeated values are added to the docstring. I also compared it withsorted()on 18,000 random lists (lengths 0-59, values -4..4): 0 mismatches after the change.Checklist
I left "all my own work" unticked on purpose: this change was written with AI assistance (Claude Code, as
AGENTS.mdinvites). I found the problem by comparing every function insorts/againstsorted()on random lists, reproduced it, and ran the doctests,ruff checkandruff format --checkon the changed file.