Skip to content

Added A* algorithm - #1913

Merged
itsvinayak merged 8 commits into
TheAlgorithms:masterfrom
jeffin07:astar
May 9, 2020
Merged

Added A* algorithm#1913
itsvinayak merged 8 commits into
TheAlgorithms:masterfrom
jeffin07:astar

Conversation

@jeffin07

@jeffin07jeffin07 commented Apr 29, 2020

Copy link
Copy Markdown
Contributor

Describe your change:

Implemented A* algorithm

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss

cclauss commented Apr 29, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Please click the Details links next to the ❌ below to see why our tests are failing. This first one is spellchecker and the second one is a linter (hint: use four spaces instead of tabs for indentation).

@cclauss

cclauss commented Apr 30, 2020

Copy link
Copy Markdown
Member

ImportMismatchError? https://travis-ci.com/github/TheAlgorithms/Python/builds/162981274#L800

@jeffin07

jeffin07 commented Apr 30, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@cclauss any idea about what causing

ImportMismatchError?
I tried the find . -name \*.pyc -delete but no change

cclauss
cclauss reviewed May 2, 2020
View reviewed changes
Comment threadmachine_learning/astar.py Outdated
itsvinayak
itsvinayak requested changes May 4, 2020
View reviewed changes
Comment threadmachine_learning/a_star.py Outdated
@itsvinayak
itsvinayak requested review from cclauss and itsvinayak and removed request for itsvinayakMay 4, 2020 14:01
@itsvinayak
itsvinayak merged commit 77c3e5b into TheAlgorithms:masterMay 9, 2020
@cclauss

cclauss commented May 10, 2020

Copy link
Copy Markdown
Member

Why was this merged with failing tests?

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@jeffin07@stokhos
Added A* algorithm (TheAlgorithms#1913)
15b4e3d
* a* algorithm
* changes after build error
* intent changes
* fix after review
* ImportMissmatchError
* Build failed fix
* doctest changes
* doctest changes
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsvinayakitsvinayakitsvinayak approved these changes
@cclausscclaussAwaiting requested review from cclauss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeffin07@cclauss@itsvinayak