Uh oh!
There was an error while loading. Please reload this page.
Add tests and type hints to hill cipher - #1991
Conversation
poyea
left a comment
There was a problem hiding this comment.
Thank you for your pull request!🤩
cclauss
commented
May 18, 2020
@bharath5412 I did not notice this before but these changes raise a ton of pytest warnings. Would you be willing to create a new pull request that eliminates these warnings? Given how little of numpy is actually used, would it be easy to remove the dependency on numpy? Thanks. |
bharath-kotha
commented
May 18, 2020
I can work on removing the dependency on numpy. But the code uses matrix operations such as determinant and inversion of a matrix. They themselves are slightly complex piece of codes. @cclauss do you think that the dependency should be removed? I can make a PR to remove the numpy dependency. |
If you believe that we are using sufficient numpy functionality then we can leave things as they are. |
bharath-kotha
commented
May 19, 2020
Cool. I'll check how complex the methods are. If they are not complex, I'll implement and do a PR. |
* Added tests and type hints to hill cipher * Remove extra >>> * import doctest Co-authored-by: John Law <johnlaw.po@gmail.com>
Describe your change:
Added doctests to the hill cipher algorithm and added type hints. This addresses the issue the #1788 .
There was a previous attemp #1862 to fix the issue but it wasn't merged.
Checklist:
Fixes: #{$ISSUE_NO}.