Skip to content

Update scoring_functions.py - #2291

Merged
cclauss merged 3 commits into
TheAlgorithms:masterfrom
tanujdhiman:patch-2
Sep 9, 2020
Merged

Update scoring_functions.py#2291
cclauss merged 3 commits into
TheAlgorithms:masterfrom
tanujdhiman:patch-2

Conversation

@tanujdhiman

@tanujdhimantanujdhiman commented Aug 8, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

We can find accuracy by manually if we are not going to use sklearn library.

@tanujdhiman
Update scoring_functions.py
63b5618
We can find accuracy by manually if we are not going to use sklearn library.
@TravisBuddy

TravisBuddy commented Aug 8, 2020

Copy link
Copy Markdown

Hey @tanujdhiman,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1a44c980-d978-11ea-b7d0-872145514bcc

@cclauss

cclauss commented Aug 8, 2020

Copy link
Copy Markdown
Member

https://travis-ci.com/github/TheAlgorithms/Python/builds/178988952#L252

@stale

staleBot commented Sep 7, 2020

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestaleBot added the stale Used to mark an issue or pull request stale. label Sep 7, 2020
@spamegg1

spamegg1 commented Sep 9, 2020

Copy link
Copy Markdown
Contributor

@tanujdhiman All you need to do is remove whitespaces from lines 143 and 145

@stalestaleBot removed the stale Used to mark an issue or pull request stale. label Sep 9, 2020
@tanujdhiman

tanujdhiman commented Sep 9, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@spamegg1 I think it is a good practice of not dependent on some library like Sklearn. It's my suggestion. What are your views ?

cclauss
cclauss requested changes Sep 9, 2020
View reviewed changes
Comment threadmachine_learning/scoring_functions.py Outdated
@cclauss
cclauss merged commit 25946e4 into TheAlgorithms:masterSep 9, 2020
@TravisBuddy

TravisBuddy commented Sep 9, 2020

Copy link
Copy Markdown

Hey @tanujdhiman,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ade9f340-f2be-11ea-82b8-f1691ab9f797

tanujdhiman
tanujdhiman commented Sep 9, 2020
View reviewed changes

@tanujdhimantanujdhiman left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@tanujdhiman@cclauss@stokhos
Update scoring_functions.py (TheAlgorithms#2291)
b27760b
* Update scoring_functions.py
We can find accuracy by manually if we are not going to use sklearn library.
* Update scoring_functions.py
* Update machine_learning/scoring_functions.py
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tanujdhiman@TravisBuddy@cclauss@spamegg1