Skip to content

Update pigeon_sort.py - #2359

Merged
dhruvmanila merged 3 commits into
TheAlgorithms:masterfrom
asukaminato0721:patch-4
Nov 30, 2020
Merged

Update pigeon_sort.py#2359
dhruvmanila merged 3 commits into
TheAlgorithms:masterfrom
asukaminato0721:patch-4

Conversation

@asukaminato0721

@asukaminato0721asukaminato0721 commented Aug 27, 2020

Copy link
Copy Markdown

Describe your change:

Update pigeon_sort.py

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy

TravisBuddy commented Aug 27, 2020

Copy link
Copy Markdown

Hey @wuyudi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 52421fa0-e859-11ea-a3ad-29627dfdd765

l3str4nge
l3str4nge previously requested changes Sep 25, 2020
View reviewed changes
Comment threadsorts/pigeon_sort.py Outdated
kbakdev
kbakdev suggested changes Oct 22, 2020
View reviewed changes
Comment threadsorts/pigeon_sort.py
@stale

staleBot commented Nov 21, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestaleBot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020
poyea
poyea approved these changes Nov 26, 2020
View reviewed changes

@poyeapoyea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@stalestaleBot removed the stale Used to mark an issue or pull request stale. label Nov 26, 2020
@ghostghost added the awaiting reviews This PR is ready to be reviewed label Nov 26, 2020
@ghostghost mentioned this pull request Nov 28, 2020
Closed
14 tasks
ghost
ghost approved these changes Nov 30, 2020
View reviewed changes

@ghostghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruvmanila check this out

dhruvmanila
dhruvmanila approved these changes Nov 30, 2020
View reviewed changes

@dhruvmaniladhruvmanila left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghostghost removed the awaiting reviews This PR is ready to be reviewed label Nov 30, 2020
@dhruvmanila
dhruvmanila dismissed l3str4nge’s stale reviewNovember 30, 2020 14:59

Changes have been made.

@dhruvmanila
dhruvmanila merged commit 07a4ce9 into TheAlgorithms:masterNov 30, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
wuyudi@stokhos
Update pigeon_sort.py (TheAlgorithms#2359)
b0aab7b
* Update pigeon_sort.py
* Update pigeon_sort.py
* Update pigeon_sort.py
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
wuyudi@peRFectBeliever
Update pigeon_sort.py (TheAlgorithms#2359)
2263909
* Update pigeon_sort.py
* Update pigeon_sort.py
* Update pigeon_sort.py
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
wuyudi
Update pigeon_sort.py (TheAlgorithms#2359)
290281b
* Update pigeon_sort.py
* Update pigeon_sort.py
* Update pigeon_sort.py
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
wuyudi@shermanhui
Update pigeon_sort.py (TheAlgorithms#2359)
6836dcd
* Update pigeon_sort.py
* Update pigeon_sort.py
* Update pigeon_sort.py
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyeapoyeapoyea approved these changes
@dhruvmaniladhruvmaniladhruvmanila approved these changes
@l3str4ngel3str4ngel3str4nge left review comments
+3 more reviewers
@kbakdevkbakdevkbakdev requested changes
@swapnanilduttaswapnanilduttaswapnanildutta approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@asukaminato0721@TravisBuddy@poyea@l3str4nge@swapnanildutta@kbakdev@dhruvmanila