Skip to content

file-transfer: writing tests and ensuring that all is going well - #2413

Merged
cclauss merged 5 commits into
TheAlgorithms:masterfrom
meysam81:test/send-file
Sep 11, 2020
Merged

file-transfer: writing tests and ensuring that all is going well#2413
cclauss merged 5 commits into
TheAlgorithms:masterfrom
meysam81:test/send-file

Conversation

@meysam81

@meysam81meysam81 commented Sep 10, 2020

Copy link
Copy Markdown
Contributor

Describe your change:

I added tests for improving coverage as mentioned in #2128

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss reviewed Sep 10, 2020
View reviewed changes
Comment threadfile_transfer/send_file.py Outdated
@TravisBuddy

TravisBuddy commented Sep 11, 2020

Copy link
Copy Markdown

Hey @meysam81,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 7f43b680-f470-11ea-a882-ef0b60d9fbb3

@TravisBuddy

TravisBuddy commented Sep 11, 2020

Copy link
Copy Markdown

Hey @meysam81,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ddb088b0-f470-11ea-a882-ef0b60d9fbb3

@TravisBuddy

TravisBuddy commented Sep 11, 2020

Copy link
Copy Markdown

Travis tests have failed

Hey @meysam81,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 03d7b9e0-f472-11ea-a882-ef0b60d9fbb3

cclauss
cclauss approved these changes Sep 11, 2020
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice example of how to mock and test communications code.

@cclauss
cclauss merged commit 2e790ce into TheAlgorithms:masterSep 11, 2020
@meysam81
meysam81 deleted the test/send-file branch September 14, 2020 17:28
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@meysam81@cclauss@stokhos
file-transfer: writing tests and ensuring that all is going well (The…
37a002c
…Algorithms#2413)
* file-transfer: writing tests and ensuring that all is going well
* def send_file(filename: str = "mytext.txt", testing: bool = False) -> None:
* send_file(filename="mytext.txt", testing=True)
* Update send_file.py
* requirements.txt: lxml
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meysam81@TravisBuddy@cclauss